Giter VIP home page Giter VIP logo

Comments (7)

kanekosh avatar kanekosh commented on June 24, 2024

I believe the optimization setup (i.e., whether aero or aerostruct) doesn't matter for generate_vsp_surfaces function. Thus if vsp_model.vsp3 works with aerodynamic optimization cases but not for aerostructural with wing box, then the issue might be in plot_wingbox or in runscript. I'm not sure though.
Could you try plotting the surfaces by yourself using matplotlib (but not the plot_wingbox function of OAS) to see if it looks fine?

from openaerostruct.

Aviatims avatar Aviatims commented on June 24, 2024

I will have a try at plotting the surfaces. I included the runscript in the description above. To create this I followed the steps as described. I first assumed it has something to do with the symmetry, as I noticed in the wing_box example from the documentation, that the one side of the wingbox was represented correctly while the other was displaying a sharp edge, as if some nodes of the wingbox are missing in the plotwingbox command. See the following two pictures:
right side:
image
left side:
image

And if you look closely in the picture provided in the first bug description the center of the wingbox also has a sharp edge while the other side is a rectangular cross section.

This however did not lead to an improvement. Have you tried running the attached runscript to see if you get a similar issue?

All of these observations lead me to the conclusion that the problem is probably in the file which generates the wingbox. Maybe in the wingbox_group.py file in the structures folder.

from openaerostruct.

Aviatims avatar Aviatims commented on June 24, 2024

But I will look into the plot_wingbox file to see if it is a plotting error.

from openaerostruct.

Aviatims avatar Aviatims commented on June 24, 2024

Hello, I just wanted to ask whether there is an update on if the problem also occurs for you/other users.
I have tried a couple of things but haven't solved the issue yet.

from openaerostruct.

kanekosh avatar kanekosh commented on June 24, 2024

Sorry Tim, we don't have time to work on this issue for a while.

from openaerostruct.

Aviatims avatar Aviatims commented on June 24, 2024

I have figured out the issue. The mesh that is being generated in the generate_vsp_surfaces function located in the utils folder needs to be of a different convention for the aerostructural case compared to the aerodynamic case. I achieved this by including the following lines:
x=x[::-1] # for aerostruct mesh
y=y[::-1] # for aerostruct mesh
z=z[::-1] # for aerostruct mesh

and modifying:
mesh[:, :, 1] = np.flipud(y.T)*-1 #-1 for aerostruct mesh

This creates the right mesh format needed for the aerostructural case.

from openaerostruct.

kanekosh avatar kanekosh commented on June 24, 2024

I finally had time to reproduce the bug by myself.
The generate_vsp_surfaces function generates a symmetric wing on the right-side plane (whose spanwise coordinate y is positive), whereas most of the other examples in OAS use a left-side wing (whose y is negative). And it seems that aerostructural analysis (both tubular and wingbox) only works with left-side wings and only the aero analysis can handle the right-side wing.

I consider this bug to be of aerostructural analysis rather than the VSP import. I'll close this issue and open another one.
A workaround is to convert the right-side wing to the left-side wing as you posted above. Thanks for finding this out.

from openaerostruct.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.