Unify the ESP32 and ESP8266 version. about asynctcp HOT 14 CLOSED

@BlackEdder Thanks! I see an error. I'll take a look soon and reply here. Temporary solution is to put ESPAsyncTCP to ignore list for ESP32 build environment

[env:esp32]
...
lib_ignore = ESPAsyncTCP

from asynctcp.

switching is quite easy ;) it's done by define switch like here: https://github.com/me-no-dev/ESPAsyncWebServer/blob/master/src/ESPAsyncWebServer.h#L31-L39
Platformio also has ways for that to work (it should with later versions out of the box. also look at the web server lib config).
With what you have above, you first have a copy of this lib and second will miss on development for each platform. It was not worth it keeping them in the same lib because the platforms are vastly different and that will only cause code clutter.
Not to say I do not even see you mention my two libs in your readme ;)

from asynctcp.

The problem I keep running into is that when I compile for one board and then the other platformio tries to include both libraries, i.e. I have to delete the temporary directories before I can switch. Maybe I am doing something wrong though, but I'd rather not have users have to deal with that.

Not to say I do not even see you mention my two libs in your readme ;)

The development is on a merge request currently ;) Will certainly add a reference when/if merged

from asynctcp.

@ivankravets have a clue about this? I would rather @BlackEdder not have to use some sort of both libs into one to make it work.

@BlackEdder would be much better if you try to make it work as it should, instead of going the way you went ;)

from asynctcp.

@ivankravets You can recreate the issue I mean by running:

git clone https://gitlab.com/BlackEdder/painlessMesh.git
cd painlessMesh
pio run -t upload -e nodemcuv2 -d examples/webServer/
pio run -t upload -e esp32 -d examples/webServer/

The nodemcuv2 build will work, while the esp32 build will fail, because it tries to include ESPAsyncTCP.cpp

from asynctcp.

@BlackEdder Just replace ESPAsyncWebServer with AsyncWebServer in https://gitlab.com/BlackEdder/painlessMesh/blob/master/examples/webServer/platformio.ini#L17

See

• https://github.com/me-no-dev/ESPAsyncWebServer/blob/master/espressif8266_library.json
• https://github.com/me-no-dev/ESPAsyncWebServer/blob/master/espressif32_library.json

from asynctcp.

from asynctcp.

@ivankravets Thanks!

I guess there is no lib_ignore for library.json? That way the library that depends on either AsyncTCP or ESPAsyncTCP could lib_ignore the one that causes a conflict :)

from asynctcp.

I'm seeing similar problems as @BlackEdder with library resolution, see platformio/platformio-core#1111. I've also switched to lib_ignore for short-term fix. This inlcudes ignoring AsyncTCP on ESP8266, too.

from asynctcp.

This is a bug and we have an issue for that platformio/platformio-core#1153

I'm going to fix it as soon as possible.

from asynctcp.

many thanks! works like a charm!

from asynctcp.

[STALE_SET] This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

from asynctcp.

[STALE_DEL] This stale issue has been automatically closed. Thank you for your contributions.

from asynctcp.

I have a similar problem with VisualMicro. When compiling with ESP8266 or ESP32 it tries to include AsyncTCP.h and ESPAsyncTCP.h in both cases. Should I blame VisualMicro?

from asynctcp.