Giter VIP home page Giter VIP logo

Comments (9)

rafa8626 avatar rafa8626 commented on May 14, 2024

Thanks for reporting this. I'll proceed to fix this on the plugin. This workflow was added due to an accessibility issue in Safari. I'll keep you posted when fixed.

from mediaelement-plugins.

rafa8626 avatar rafa8626 commented on May 14, 2024

@ahushh Can you download the master branch and test again please?

from mediaelement-plugins.

ahushh avatar ahushh commented on May 14, 2024

It works, but title attribute is ignored. Can it be fixed?

from mediaelement-plugins.

rafa8626 avatar rafa8626 commented on May 14, 2024

Download the master branch of MediaElement, it already has that fix.

from mediaelement-plugins.

rafa8626 avatar rafa8626 commented on May 14, 2024

Let me know if it worked for you

from mediaelement-plugins.

ahushh avatar ahushh commented on May 14, 2024

I'm using master branch and source title is missing.

		for (var _i = 0, _total = sources.length; _i < _total; _i++) {
			var src = sources[_i];
			if (src.type !== undefined && typeof media.canPlayType === 'function') {
				player.addSourceButton(src.src, src.title, src.type, media.src === src.src);
			}
		}

src.title is undefined.

from mediaelement-plugins.

rafa8626 avatar rafa8626 commented on May 14, 2024

The master branch of the player itself (https://github.com/mediaelement/mediaelement), not this one, has the fix for the title attribute

from mediaelement-plugins.

ahushh avatar ahushh commented on May 14, 2024

Yes, it works, thanks!

from mediaelement-plugins.

rafa8626 avatar rafa8626 commented on May 14, 2024

Glad to know it worked. Please star us to continue giving the package more popularity, and also tell your friends/coworkers/etc. to support the project, if you don't mind. Also, if you can star us at https://github.com/mediaelement/mediaelement, it would be greatly appreciated it

from mediaelement-plugins.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.