Giter VIP home page Giter VIP logo

Comments (46)

rafa8626 avatar rafa8626 commented on May 14, 2024 1

You are welcome :)

from mediaelement-plugins.

rafa8626 avatar rafa8626 commented on May 14, 2024

Thanks for reporting this. It should be by default so I'm checking it right now. I'll keep you posted.

from mediaelement-plugins.

DeysonOrtiz avatar DeysonOrtiz commented on May 14, 2024

Wow. You are fast! Thank you good sir! :)

from mediaelement-plugins.

rafa8626 avatar rafa8626 commented on May 14, 2024

Done. Check the fix by downloading the latest version of the package and let me know

from mediaelement-plugins.

DeysonOrtiz avatar DeysonOrtiz commented on May 14, 2024

The audio gets muted now. :) The only thing missing is for the audio level controller to go down as well. Right now the audio is mute but the level bar stays up. Thank you :)

from mediaelement-plugins.

rafa8626 avatar rafa8626 commented on May 14, 2024

Gotcha. Working on it right now

from mediaelement-plugins.

DeysonOrtiz avatar DeysonOrtiz commented on May 14, 2024

Also, it seems that if we click on the speaker icon again the audio does not unMute.
My recommendation is when a person clicks on the speaker to mute it, the speaker gets the little X you have when audio is down as well, to show that it is mute. Thank you :)

from mediaelement-plugins.

rafa8626 avatar rafa8626 commented on May 14, 2024

Interesting. I see the right behavior.
screen shot 2017-01-25 at 9 58 39 am
screen shot 2017-01-25 at 9 58 44 am

from mediaelement-plugins.

rafa8626 avatar rafa8626 commented on May 14, 2024

Same for video
screen shot 2017-01-25 at 10 00 12 am
screen shot 2017-01-25 at 10 00 19 am

from mediaelement-plugins.

DeysonOrtiz avatar DeysonOrtiz commented on May 14, 2024

That is odd. It does work on yours but not mine.

from mediaelement-plugins.

rafa8626 avatar rafa8626 commented on May 14, 2024

What OS and browser are you using so I can check it? Also did you download the latest version of the plugin?

from mediaelement-plugins.

DeysonOrtiz avatar DeysonOrtiz commented on May 14, 2024

Let me re-download and test again. I am on the latest OSX and using Safari and Firefox.

from mediaelement-plugins.

DeysonOrtiz avatar DeysonOrtiz commented on May 14, 2024

Just to confirm: The best place to download is from your live site: http://www.mediaelementjs.com ?

from mediaelement-plugins.

rafa8626 avatar rafa8626 commented on May 14, 2024

From there or GitHub directly doesn't matter

from mediaelement-plugins.

DeysonOrtiz avatar DeysonOrtiz commented on May 14, 2024

Here is the link to my testing site. I have included the top video which is on its own and the thumbnail videos, which I am testing for my video gallery: https://mmt.staging.wpengine.com/vimeo-embed-test-4/

from mediaelement-plugins.

rafa8626 avatar rafa8626 commented on May 14, 2024

This is the first thing I see:
screen shot 2017-01-25 at 10 20 29 am

from mediaelement-plugins.

rafa8626 avatar rafa8626 commented on May 14, 2024

Also, make sure to clear your cache just in case because that had happened to me in the past.

from mediaelement-plugins.

DeysonOrtiz avatar DeysonOrtiz commented on May 14, 2024

I do not know what may cause this error. I wonder if maybe Vimeo's pickiness for Https. since this is a development site. But I do not think it would cause the volume issue. I will clear cache now.

from mediaelement-plugins.

DeysonOrtiz avatar DeysonOrtiz commented on May 14, 2024

One thing I forgot to point out is that I have to use this script or the videos will not load. This does not match your documentation on your site, though.

<script type="text/javascript">jQuery(document).ready(function($) { $('#mejs-player').mediaelementplayer(); }); </script>

from mediaelement-plugins.

DeysonOrtiz avatar DeysonOrtiz commented on May 14, 2024

Cleared Cache and still get the mute not working.

from mediaelement-plugins.

DeysonOrtiz avatar DeysonOrtiz commented on May 14, 2024

I wonder if it has anything to do with With Vimeo background off feature we are testing?

from mediaelement-plugins.

rafa8626 avatar rafa8626 commented on May 14, 2024

Yesterday I fixed some issues related to jQuery since users in Wordpress and Drupal couldn't use it, and they confirmed it can be used now. Can you try just using this:

<script type="text/javascript">
$(document).ready(function() { 
    $('#mejs-player').mediaelementplayer(); 
}); 
</script>

so I can check what other things might be happening, please?

from mediaelement-plugins.

rafa8626 avatar rafa8626 commented on May 14, 2024

I see it working now

from mediaelement-plugins.

rafa8626 avatar rafa8626 commented on May 14, 2024

Nevermind I thought it was working

from mediaelement-plugins.

rafa8626 avatar rafa8626 commented on May 14, 2024

One thing I did notice is that the controls look like blurry for some reason

from mediaelement-plugins.

rafa8626 avatar rafa8626 commented on May 14, 2024

I'd also try to use the unminified version of the plugin to give it a try.

from mediaelement-plugins.

DeysonOrtiz avatar DeysonOrtiz commented on May 14, 2024

I used the new script linked above. The larger video play, but the small thumbnails do not. Please note this is a for wordpress site. P.S. Speaker mute not working. I will try the min version now.

from mediaelement-plugins.

rafa8626 avatar rafa8626 commented on May 14, 2024

Oh, I figured out what is it: it's because of the parameters of Vimeo related to background. The problem of using that (I found out this later last night) is that the API won't respond to all of the events. That's a limitation of using that parameter

from mediaelement-plugins.

rafa8626 avatar rafa8626 commented on May 14, 2024

I'm testing one more thing, but I'll keep you posted. That might not be entirely the cause of the issue.

from mediaelement-plugins.

DeysonOrtiz avatar DeysonOrtiz commented on May 14, 2024

That is what I had thought, Darn vimeo!! :)

from mediaelement-plugins.

DeysonOrtiz avatar DeysonOrtiz commented on May 14, 2024

It seems the background feature may be limiting.

from mediaelement-plugins.

rafa8626 avatar rafa8626 commented on May 14, 2024

Well, go figure out. It's not the background parameter: is the api parameter. I disabled it and now it works. I'm testing some more but I'll let you know. It should be ready in a couple of minutes

from mediaelement-plugins.

DeysonOrtiz avatar DeysonOrtiz commented on May 14, 2024

Thank you :)

from mediaelement-plugins.

rafa8626 avatar rafa8626 commented on May 14, 2024

OK I'll strongly advise you not to use background until it stops being experimental. Doesn't mean you can't use it, but you will have to write more JS code to stop the autoplay. The reason why volume (and other things) don't work is because api=1 is for Froogaloop. So not all the arguments in the query string will work. You can download the latest version of the package and it should work now

from mediaelement-plugins.

DeysonOrtiz avatar DeysonOrtiz commented on May 14, 2024

That makes sense. Let me test your new download. Thank you so much for all your wonderful help. :)

from mediaelement-plugins.

DeysonOrtiz avatar DeysonOrtiz commented on May 14, 2024

Just to confirm? Are we testing the new JS Script now, since the api=1 will not work for the speaker mute?

<script type="text/javascript"> $(document).ready(function() { $('#mejs-player').mediaelementplayer(); }); </script>

from mediaelement-plugins.

rafa8626 avatar rafa8626 commented on May 14, 2024

Yeah API won't work anymore since we are not using froogaloop

from mediaelement-plugins.

DeysonOrtiz avatar DeysonOrtiz commented on May 14, 2024

Got it.
The new script does not work on the video gallery. But it does on the large one on top: http://mmt.staging.wpengine.com/vimeo-embed-test-4/

I am using the new script within in the loop:

'<script type="text/javascript">
$(document).ready(function() {
$('#').mediaelementplayer();
});
</script>'

This is the loop script that had worked before:
'<script type="text/javascript">jQuery(document).ready(function($) {
$('#').mediaelementplayer();
});
</script>'

from mediaelement-plugins.

DeysonOrtiz avatar DeysonOrtiz commented on May 14, 2024

Please hold on. It seems I may have discovered a conflict on my end. Thank you. :)

from mediaelement-plugins.

DeysonOrtiz avatar DeysonOrtiz commented on May 14, 2024

Ok. It is working now: https://mmt.staging.wpengine.com/test-mixitup/

Good thing I was working on a different layout to catch this. Thank you again for all the great work. The speaker mute works now. The only thing missing the tap on the video to pause it. But from what I understand this will not work right now because of the API=0 and Background=1. Correct?

from mediaelement-plugins.

rafa8626 avatar rafa8626 commented on May 14, 2024

correct :) it's a limitation of this approach. Thanks. Closing this issue now

from mediaelement-plugins.

DeysonOrtiz avatar DeysonOrtiz commented on May 14, 2024

With this limitation can we pause all the video with a button or another trigger. I had hoped to pause the videos when we click on the filter controls. Or all pause/play controls non-functional with Background=1 other than the one in the player controls?

I would like to know what our limitations are before I begin to design around it. Thank you again for all your great help! :)

from mediaelement-plugins.

rafa8626 avatar rafa8626 commented on May 14, 2024

You can still pause it with the play/pause in the control bar; the only one behavior that won't work is when you click on the video to play or pause

from mediaelement-plugins.

DeysonOrtiz avatar DeysonOrtiz commented on May 14, 2024

Thank you! What is the best way to pay back the favor for all the help you have shown us?

from mediaelement-plugins.

rafa8626 avatar rafa8626 commented on May 14, 2024

Just star both projects: the plugins and the mediaelement one and tell your peers that do the same. In the end, it's an open source project and I just want to make sure you are using the best. Knowing that we don't have as many bugs as we had in the past it's my satisfaction. If you wanna post something in social media about the plugin or the help you have received or link back to https://github.com/johndyer/mediaelement, etc. Whatever you can help us to gain visibility again it would be awesome man. I'm glad I could help you

from mediaelement-plugins.

DeysonOrtiz avatar DeysonOrtiz commented on May 14, 2024

I will! Thank you again for all your hard work. I will have some new requests in the near future and I look forward to your awesome help! Thank you again! :)

from mediaelement-plugins.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.