Giter VIP home page Giter VIP logo

Comments (3)

garethbowen avatar garethbowen commented on June 14, 2024

Related to #26

from cht-android.

mrsarm avatar mrsarm commented on June 14, 2024

@garethbowen why we would allow users (not just developers) to provide invalid URLs? I don't think it's a good idea, but maybe there is a good reason.

There is a environment variable that acts as flag: DISABLE_APP_URL_VALIDATION, that allows developers at build time to assemble any flavor disabling the validation:

cht-android/Makefile

Lines 65 to 66 in 672a273

url-tester:
DISABLE_APP_URL_VALIDATION=true ${GRADLE} ${GRADLE_OPTS} install${flavor}Debug
allowing to load URLs that aren't CHT apps, but this options is used for developers who know what they are doing.

We also use it to run one of the UI tests:

cht-android/Makefile

Lines 82 to 85 in 672a273

test-ui-url:
DISABLE_APP_URL_VALIDATION=true ${GRADLE} connectedUnbrandedWebviewDebugAndroidTest \
-Pabi=${abi} --stacktrace -Pandroid.testInstrumentationRunnerArguments.class=\
org.medicmobile.webapp.mobile.LastUrlTest

Maybe what we should do is add documentation about this feature, but close the issue.

from cht-android.

garethbowen avatar garethbowen commented on June 14, 2024

I can't remember exactly why this was raised either, and it's now so ancient I'm happy to just close it. The only thing I can think of is testing something out, and you don't want to have to build the apk from scratch.

Let's add the documentation and close, like you suggest.

from cht-android.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.