Comments (5)
Hi Chris, I couldn't get those unit tests to work with Bitcoinj, so I didn't update them for my part of the work, as it could be a couple of month long project; I just translated Bitcoinj to work with floj, but I didn't repair any of bitcoinj's inherent problems.
from floj.
Okay, thanks, that's good to know. We'll (the floj community, I hope) attack them later.
from floj.
In Bitcoinj, tags v0.14.7
and the master branch pass all tests for me without any changes; previous versions require skipping the PaymentSessionTest
and ignoring testless projects thus: -Dtest='!PaymentSessionTest' -DfailIfNoTests=false
(The version tagged segwit
also requires skipping KeyChainGroupTest, eg. -Dtest='!PaymentSessionTest,!KeyChainGroupTest' -DfailIfNoTests=false
)
Currently in this project, there are 4 tests that hang, so we have to run the following in order to bypass those tests:
mvn package -Dtest='!FilteredBlockAndPartialMerkleTreeTests,!PeerGroupTest,!PeerTest,!TransactionBroadcastTest'
That gives the output: Tests run: 5119, Failures: 347, Errors: 153, Skipped: 4
I could see skipping those 4 tests (maybe they require additional, network-related infrastructure?), though I have a feeling they'll work after other unit tests are fixed.
@Rengelking What version of bitcoinj did you fork (against which you couldn't get unit tests to work)?
from floj.
Looking over the non-hanging tests, I think close to all of them are related to the changes of parameters from Bitcoint to FLO. I've created a new branch, failing-tests-repair
, that will be for fixing code or the tests to pass.
from floj.
For those helping with the tests, create your own branch for a fix then a pull request from yours to failing-tests-repair
.
from floj.
Related Issues (6)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from floj.