Improve shell script arguments handling about modules-webmake HOT 9 OPEN

Can you prepare some good test case, that would reproduce that on my side? I haven't seen issues using ignoreErrors option.

from modules-webmake.

I created a test: https://github.com/fluidblue/webmake-test

When you execute make, webmake is called without --ignoreerrors and everything is fine. When executing make test, webmake is called with --ignoreerrors and it throws an error like this:

webmake --ext=coffee --ignoreerrors ./src/test.coffee ./build/test.js

/usr/local/lib/node_modules/webmake/node_modules/deferred/lib/_ext.js:71
            throw this.value;
                      ^
Error: ENOENT, open '/Users/max/Desktop/webmake-test/build/test.js'

from modules-webmake.

@fluidblue thanks.

Issue lies in your build script, you call: webmake --ext=coffee --ignoreerrors ./src/test.coffee ./build/test.js, which translates to webmake('./build/test.js', { ext: 'coffee', sourceMap: false, ignoreErrors: false }).

Thing is that it should be --ignore-errors, not --ignoreerrors. Latter is unrecognized option, and argument that follows that is taken as its value (it's swallowed).

I'll rename this issue, to "Improve shell script arguments handling", and leave it open until we have it more bulletproof so such errors doesn't come as unnoticed.

from modules-webmake.

Ah I see. Now it works.

It is a little bit confusing, that the sourceMap option is --sourcemap on the commandline whereas ignoreErrors is --ignore-errors

It might be helpful to include the commandline equivalents in the options documentation.

from modules-webmake.

@fluidblue that's true, it's not consistent. I'll probably fix this and assure consistency from v0.4

from modules-webmake.

please update the docs with examples of how to use the command line args. it's not obvious that the args should be used in the way you describe in this issue.

i've run into this issue as well, but with different arguments (sourcemap).

from modules-webmake.

@boxxxie in documentation, there's a command line name for each option provided: https://github.com/medikoo/modules-webmake#options, e.g.:

How would you improve it?

from modules-webmake.

examples, like how man files give a few examples of command use.

in this case, i have no idea how to use sourcemap when writing my script. do i do -- sourcemap -sourcemap --sourcemap or just sourcemap

from modules-webmake.

@boxxxie this falls into general knowledge on construction of CLI params. Follow: https://betterdev.blog/command-line-arguments-anatomy-explained/

from modules-webmake.