Giter VIP home page Giter VIP logo

Comments (6)

srindom avatar srindom commented on September 12, 2024 1

Hi @yehiatarek63 - in v1 we don't have translation keys for settings titles and descriptions and we won't be able to find time to work on this. However, everything is translatable in v2.

I will close this for now, if someone is willing to work on adding translation keys for settings in v1 we'd be happy to accept a PR.

from medusa.

yehiatarek63 avatar yehiatarek63 commented on September 12, 2024

@srindom Thanks, I just wanted to ask, has multi-language been implemented yet in v2? I installed it and took a look but only English is available as of now and will there be RTL support for RTL languages?

from medusa.

srindom avatar srindom commented on September 12, 2024

The admin application is ready for internationalization, but we only have an English file so far (https://github.com/medusajs/medusa/blob/develop/packages/admin-next/dashboard/public/locales/en-US/translation.json). New translations files will have to be added for other locales.

We haven't built RTL support into the new dashboard. I don't know much about the requirements for this. Is it simply a question of using dir="rtl" on the HTML tag and ensuring the styles take direction into account or is there more to it?

from medusa.

yehiatarek63 avatar yehiatarek63 commented on September 12, 2024
  1. I can contribute to the arabic translation and make a PR
  2. To support RTL, we need to change dir="rtl".
  3. RTL version of the CSS is required
  4. RTL layout affects Arabic, Hebrew, Aramaic, Persian, Urdu and Kurdish
  5. Make sure that any SVGs like arrows are rotated in the RTL version

from medusa.

srindom avatar srindom commented on September 12, 2024

We would be happy to accept an Arabic translation 🙏 I'd request that you wait a couple of weeks though since there's still plenty of active development on admin for v2. I will make a reminder to ping you when we are ready.

Regarding RTL, I don't think we will be able to prioritize this effort anytime soon. I believe we do get some help out of the box from Tailwind, however, it will be a big task to get it done across the admin application https://tailwindcss.com/blog/tailwindcss-v3#rtl-and-ltr-modifiers. If anyone feels inclined to PR it we would be happy to help make it land.

from medusa.

MEClouds avatar MEClouds commented on September 12, 2024

Hi there,

I am already working on adding RTL support and fixing some issues. I will make pull requests after finishing it. Right now, I am working on:

  • Adding RTL support
  • Fixing the UI to work correctly in RTL
  • Adding the missing translations

After I finish these tasks, I will make the pull requests.

  • RTL Support (done)
  • Fixing UI in RTL (done)
  • Adding missing translations(in progress)

image

@srindom
#8245

from medusa.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.