ping range about mylg HOT 17 CLOSED

good catch 👍 I just committed a fix pls try again and let me know. Thanks!

from mylg.

much better but what's up with this?
192.168.0.100 is alive (1481429370444.3538 ms)

Is that a sum of scanning the full /24 range?

from mylg.

did you try w/ the last commit? I did another commit today

from mylg.

Yes, this is with the latest update.

from mylg.

when you get a chance try again w/ latest code. I checked w/ diff scenarios and it passed!

from mylg.

This still repeats results in the scan.

192.168.0.1 is alive (2.6196 ms)
192.168.0.2 is alive (81.7707 ms)
192.168.0.3 is alive (0.3931 ms)
192.168.0.4 is alive (5.8295 ms)
192.168.0.5 is alive (4.5503 ms)
192.168.0.6 is alive (0.3875 ms)
192.168.0.8 is alive (8.6852 ms)
192.168.0.11 is alive (1.9782 ms)
192.168.0.12 is alive (10.4139 ms)
192.168.0.13 is alive (0.2777 ms)
192.168.0.15 is alive (0.0939 ms)
192.168.0.17 is alive (0.2249 ms)
192.168.0.20 is alive (0.2361 ms)
192.168.0.22 is alive (0.4109 ms)
192.168.0.26 is alive (0.4188 ms)
192.168.0.100 is alive (0.4068 ms)
192.168.0.137 is alive (0.6168 ms)
192.168.0.140 is alive (0.4065 ms)
192.168.0.15 is alive (0.0908 ms)

Notice this has 192.168.0.15 twice. This has the latest code from github.

from mylg.

I couldn't duplicate this issue. I remember you had same issue w/ scan

from mylg.

I couldn't duplicate this issue. I remember you had same issue w/ scan

yes, that's right and you fixed it with the code.

from mylg.

Correct, I added unique function to stop showing duplicate!

from mylg.

@gummiboll when you get a chance can you test it pls

from mylg.

I can duplicate this with a fresh build of mylg:

untzuntz:mylg emil$ sudo ./bin/mylg ping 10.0.1.0/24|grep alive
10.0.1.1 is alive (2.395 ms)
10.0.1.1 is alive (1.144 ms)
10.0.1.2 is alive (2.594 ms)
10.0.1.8 is alive (0.134 ms)
10.0.1.10 is alive (3.357 ms)
10.0.1.8 is alive (0.102 ms)

.1 is my gw and .8 is the laptop I'm pinging from if that helps

from mylg.

@gummiboll Thanks! that's help

from mylg.

@gummiboll I think the 10.0.1.1 shouldn't be showed up per last change but still no idea why 10.0.1.8 duplicated.

from mylg.

I think I found the issue for the 10.0.1.8 issue. the root cause is broadcast ip address. it should be skipped through the ping loop :-)

from mylg.

@jungle-boogie @gummiboll it fixed pls try again when you get a chance

from mylg.

You did it @mehrdadrad, good job!

untzuntz:mylg emil$ sudo ./mylg ping 10.0.1.0/24|grep alive
10.0.1.1 is alive (16.469 ms)
10.0.1.2 is alive (2.823 ms)
10.0.1.8 is alive (0.168 ms)
10.0.1.10 is alive (3.602 ms)

from mylg.

@gummiboll Thanks Emil!

from mylg.