Comments (1)
I totally agree, I think this was made to mimic c#'s dependency injection strategy, but in dart it isn't as efficient.
in HttpRequest
, all the methods are tightly coupled with dio
since they return Response<T>
, so it doesn't make sense to have HttpRequestImpl
when it's the only possible implementation for the base class
and in MeiliSearchIndex
, a user wouldn't benefit anything from implementing the abstract class, they would rather just extend the existing MeiliSearchIndexImpl
and override specific methods rather than reinvent the wheel.
similar to what we did in https://github.com/meilisearch/meilisearch-dart/blob/e64dd6368936e06c8e47e1d9c7c6d50aff1e2cd9/test/models/test_client.dart
from meilisearch-dart.
Related Issues (20)
- Update code-samples based on docs team request (apr/23)
- [v1.3] [EXPERIMENTAL] Vector Store
- [v1.3] Define fields to search on at search-time (`attributesToSearchOn`)
- [v1.3] Display hits ranking scores
- [v1.3] [EXPERIMENTAL] Display ranking details at search
- [v1.3] Sort facets value by alphanumerical or count order
- [v1.3] Search in facet values `facetSearch`
- [v1.3] Total Tasks in task route
- Ensure the error handling are following the best practice HOT 2
- Add CodeCov HOT 1
- Add section about the new `MeiliDocumentContainer<T>` class in readme
- [v1.4] Support text-separator customization
- [v1.4] Support user-dictionary loading HOT 2
- [v1.5] Add a new method for creating snapshots
- [v1.6] Implement vector search experimental feature HOT 2
- [v1.6] Support `proximityPrecision` setting
- Add support of dio cancel tokens HOT 1
- Pana CI is failing HOT 1
- Impossible to deploy on Pub.dev HOT 2
- [v1.8] Support `searchCutoffMs` setting
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from meilisearch-dart.