Giter VIP home page Giter VIP logo

Comments (5)

drcongo avatar drcongo commented on May 19, 2024 3

Perfect, thanks. I actually ended up pushing a compatibility update as 0.11.0, but yeah, I take your point about how the different versions don't necessarily mean compatibility alignment. When we all hit 1.x it would make more sense.

Thanks for all the great work on this library!

from meilisearch-python.

curquiza avatar curquiza commented on May 19, 2024 1

Not a problem, the database (data.ms) is indeed not compatible between 2 minors versions of MeiliSearch, it means you have to re-populate your MeiliSearch instance! Snapshotting and back-up are currently implemented to solve that 🙂

One small question though, I was thinking I might update my versioning on wagtail-meilisearch to track the version numbers of your package, which is fairly close to tracking the version numbers of MeiliSearch itself. Does that sound like a good idea to you?

Hum, at the beginning meilisearch-python did indeed follow the same minor version (0.X.Y where X is the minor) of MeiliSearch. But we realized this is not convenient because the breaking changes of MeiliSearch do not necessarily involve breaking changes for meilisearch-python, and the opposite. So we stop that. Now, our SDKs (like meilisearch-python) follow their own versioning, so tracking the meilisearch-python version does not mean tracking the MeiliSearch version as well...
And I'm not sure I recommend your package following the meilisearch-python version for the same reason. MeiliSearch, and meilisearch-python, are not enough stable yet: we are doing a lot of changes every week.
You should follow your own versioning and when MeiliSearch will be more stable, I mean using the major, we (and you) should reconsider this possibility 🙂
(Hope I understood well your question)

from meilisearch-python.

curquiza avatar curquiza commented on May 19, 2024

Hello @drcongo! Thanks for building wagtail-meilisearch! 😁

Can you give me the version of MeiliSearch and the version of meilisearch-python you are using? 🙂
And if possible, a dataset (or a piece of your dataset) so that we can reproduce the error?

from meilisearch-python.

drcongo avatar drcongo commented on May 19, 2024

Hi @curquiza - I'm upgrading from MeiliSearch 0.9.x to 0.11.1 and using meilisearch-python 0.11.2

I've just trashed the data.ms folder and I'm currently rebuilding the index to see if that helps. One possible change that I spotted in the tracebacks was that primary_key is no longer accepted on the create_index method, so I'm now passing in options={'primaryKey': 'id'} - does this seem sensible?

Thanks!

from meilisearch-python.

drcongo avatar drcongo commented on May 19, 2024

In fact, everything seems to work now that I've rebuilt the index (and Indexing seems faster?). Sorry to have bothered you!

One small question though, I was thinking I might update my versioning on wagtail-meilisearch to track the version numbers of your package, which is fairly close to tracking the version numbers of MeiliSearch itself. Does that sound like a good idea to you?

from meilisearch-python.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.