Giter VIP home page Giter VIP logo

Comments (4)

curquiza avatar curquiza commented on May 19, 2024 1

Hello @brunoocasali! Thank for starting this huge work!

Do Meilisearch team have a set of rubocop constraints (overrides) to be used already or I'm free to suggest mine?

Nope, not at the moment

After the first execution without any overrides I got: 73 files inspected, 823 offenses detected, 684 offenses auto-correctable probably we will not refactor the entire gem in one big bang PR right? I could submit multiple pull requests with different contexts like (one for specs and so on...)

Yes, do multiple PRs is a good way to handle this issue 🙂

from meilisearch-rails.

curquiza avatar curquiza commented on May 19, 2024 1

Closed thanks to @brunoocasali's PRs in favor of #77 :D

from meilisearch-rails.

brunoocasali avatar brunoocasali commented on May 19, 2024

@curquiza I've started this locally and I had some concerns about this:

  • Do Meilisearch team have a set of rubocop constraints (overrides) to be used already or I'm free to suggest mine?
  • After the first execution without any overrides I got: 73 files inspected, 823 offenses detected, 684 offenses auto-correctable probably we will not refactor the entire gem in one big bang PR right? I could submit multiple pull requests with different contexts like (one for specs and so on...)

from meilisearch-rails.

brunoocasali avatar brunoocasali commented on May 19, 2024

@curquiza I'll try to generate the PR's separately in two ways:

  • by directory
  • by kind of change

Because if I merge both of the operations at the same PR, probably maintainers will have a bad time finding something relevant, a meaningful change or a problematic one for example.

from meilisearch-rails.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.