Giter VIP home page Giter VIP logo

Comments (8)

curquiza avatar curquiza commented on May 19, 2024 1

Hello @AudTheCodeWitch

Thanks for your interest in this project :)

FYI, we prefer not assigning people to our issues because sometimes people ask to be assigned and never come back, which discourages the volunteer contributors to open a PR to fix this issue.
We will accept and merge the first PR that fixes correctly and well implements the issue following our contributing guidelines.

We are looking forward to reviewing your PR 🙂

from meilisearch-rails.

curquiza avatar curquiza commented on May 19, 2024 1

Hello @brunoocasali
thanks for these suggestions! 😄

We should create separated issues for what you suggest (the 3rd last points) since it's not related to this issue "Remove linter errors". Feel free to open them to detail what you plan to do a little bit 🙂
One issue per idea is ok.

from meilisearch-rails.

AudTheCodeWitch avatar AudTheCodeWitch commented on May 19, 2024

I would like to work on this issue, if possible.

from meilisearch-rails.

reginaalyssa avatar reginaalyssa commented on May 19, 2024

Hi @curquiza I'm interested to work on this. Hope I can get some advice on a failing spec while running on local for spec/configuration_spec.rb. Below is what I ran:

  1. Ran ./meilisearch in one terminal
  2. While checked out on the main branch of meilisearch-rails, I ran bundle exec rspec spec/configuration_spec.rb
  3. I got the errors shown below:

image

Please let me know where I went wrong in running the steps. I unfortunately do not have docker installed on my laptop. Thank you so much!

from meilisearch-rails.

curquiza avatar curquiza commented on May 19, 2024

Hello @reginaalyssa
Did you run the required commands you can find in the CONTRIBUTING.md before running the spec?

from meilisearch-rails.

brunoocasali avatar brunoocasali commented on May 19, 2024

@curquiza I was sending many PR's but I didn’t mention what I want with them, the current approach is to:

  • Fix small problems like double quote strings and others (Code/Style ## PR's)
  • Fix most of the auto-correctable offenses (or all) (Code/Style ## PR's)
  • Replace should with expect inside specs and offenses without changes on what the tests do.
  • Start decomposing the big methods inside of the meilisearch-rails in order to fix the cyclomatic complexity
  • Make tests independent (add randomization)

(feel free to reply with your concerns)

Probably after this, the rubocop_todo would be gone!

from meilisearch-rails.

brunoocasali avatar brunoocasali commented on May 19, 2024

Yes! I'll provide the issues ASAP :)

from meilisearch-rails.

curquiza avatar curquiza commented on May 19, 2024

Thanks a lot

from meilisearch-rails.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.