Comments (8)
Hello @AudTheCodeWitch
Thanks for your interest in this project :)
FYI, we prefer not assigning people to our issues because sometimes people ask to be assigned and never come back, which discourages the volunteer contributors to open a PR to fix this issue.
We will accept and merge the first PR that fixes correctly and well implements the issue following our contributing guidelines.
We are looking forward to reviewing your PR 🙂
from meilisearch-rails.
Hello @brunoocasali
thanks for these suggestions! 😄
We should create separated issues for what you suggest (the 3rd last points) since it's not related to this issue "Remove linter errors". Feel free to open them to detail what you plan to do a little bit 🙂
One issue per idea is ok.
from meilisearch-rails.
I would like to work on this issue, if possible.
from meilisearch-rails.
Hi @curquiza I'm interested to work on this. Hope I can get some advice on a failing spec while running on local for spec/configuration_spec.rb
. Below is what I ran:
- Ran
./meilisearch
in one terminal - While checked out on the
main
branch ofmeilisearch-rails
, I ranbundle exec rspec spec/configuration_spec.rb
- I got the errors shown below:
Please let me know where I went wrong in running the steps. I unfortunately do not have docker installed on my laptop. Thank you so much!
from meilisearch-rails.
Hello @reginaalyssa
Did you run the required commands you can find in the CONTRIBUTING.md before running the spec?
from meilisearch-rails.
@curquiza I was sending many PR's but I didn’t mention what I want with them, the current approach is to:
- Fix small problems like double quote strings and others (Code/Style ## PR's)
- Fix most of the auto-correctable offenses (or all) (Code/Style ## PR's)
- Replace should with expect inside specs and offenses without changes on what the tests do.
- Start decomposing the big methods inside of the meilisearch-rails in order to fix the cyclomatic complexity
- Make tests independent (add randomization)
(feel free to reply with your concerns)
Probably after this, the rubocop_todo would be gone!
from meilisearch-rails.
Yes! I'll provide the issues ASAP :)
from meilisearch-rails.
Thanks a lot
from meilisearch-rails.
Related Issues (20)
- Semantic Search using Embeddings HOT 2
- _geoBoundingBox filter causing an error HOT 2
- Index not created since 0.11.0 - 404 Not Found HOT 8
- Upgrading to 0.11.0 produces "The request was not processed in the expected time." repeatedly. HOT 1
- Split and decouple models in integration_spec.rb to their separate files
- Improve test robustness and confidence with end-to-end system tests
- Improve spec style clarity
- Add unit tests for individual methods
- Support and test Sequel properly
- Document multi_search interface in README HOT 1
- single index sharing didnt create new index. HOT 3
- Using attribute option with custom primary key will break fetching
- Polymorphic shared indexes HOT 3
- Index-first search HOT 1
- Rename root module to `Meilisearch` instead of `MeiliSearch`
- Refactor `meilisearch.rb`
- Global `ms_without_auto_index` in `Meilisearch`
- MeiliSearch::Rails::MSCleanUpJob 404 error when deleting records HOT 3
- Update Gem dependencies HOT 5
- Error: MeiliSearch::TimeoutError: The request was not processed in the expected time. HOT 12
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from meilisearch-rails.