Comments (3)
I'm not sure I understand. It does actually report the error (via syslog
). The problem is that die()
goes through a number of extra steps, including possibly not exiting (on SGE, et al.), and so it's specifically the wrong action to take in that case. That's why I chose to only pull out a few specific lines of code from the die()
function and just execute those.
It sounds like the real issue you're getting at is that the node doesn't get offlined. If that's the case, I think the correct fix would be to add something like this:
[[ -n "$NHC_RM" && "$MARK_OFFLINE" -eq 1 ]] \
&& eval $OFFLINE_NODE "'$HOSTNAME'" "'Cannot write $LOGFILE as $USER (uid $EUID) -- Read-only filesystem/device failure?'"
Would that achieve what you're looking for?
from nhc.
It does report via syslog indeed but doesn't offline the node. I can test your suggestion on our systems and report back.
from nhc.
Hi @mehdid! Have you had the opportunity to test the suggested fix? Does it correctly address the issue?
Thanks!
from nhc.
Related Issues (20)
- bug in nhc_job_find_users() leading to misjudgment of illegal process
- `nhc_common_parse_size` doesn't support decimal values HOT 1
- "Fix" Permissions in RPM HOT 1
- Default output to stdout/stderr when the -e option is used
- Display check numbers in verbose mode
- Add option to output results in JSON
- NHC Helpers vs. Unknown Slurm States HOT 2
- Improve Script Safety with Checksum/Signature Verification?
- Version Flag HOT 1
- Improve Hostname Customization
- Pattern error message HOT 2
- Manually drained node got resumed after watchdog timer was unable to terminate hung NHC process HOT 3
- External Match doesn't work for me HOT 3
- Support for OpenPBS HOT 5
- Using something like an 'include' directive? or better with templates HOT 2
- Question: Custom Check, How to exit without any changes, i.e. leave node in current state? HOT 3
- Question for faster execution: Seeing cpu_info add 10 secs to execution HOT 4
- check_cmd_dmesg() Reason Strings Cause Problems
- Helper scripts are not called when the node fails the health check with Slurm HOT 13
- scripts/lbnl_hw.nhc: nhc_hw_gather_data is slow at parsing /proc/cpuinfo HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nhc.