Comments (5)
Exilz
commented on August 20, 2024
You're right, better safe than sorry.
I forked the repo too, and I'll try to bake it in in the next release.
If someone wants to do it, please make sure to follow the code style from the supplied .eslintrc file.
from react-native-image-gallery.
msageryd
commented on August 20, 2024
On the code style topic. Have you considered using Prettier to ensure consistent formatting?
from react-native-image-gallery.
Exilz
commented on August 20, 2024
When writing code from scratch I usually just follow eslint to make sure it's consistant.
Since I pretty much changed the whole original codebase here, maybe I should have used prettier. It might not be perfectly consistant everywhere.
from react-native-image-gallery.
msageryd
commented on August 20, 2024
I have now bundled react-native-scroller and react-native-gesture-responder into react-native-image-gallery. I'm having trouble creating a PR because of the PR you already got on the Rect-bug.
I'll make a PR out ot the bundling when you (hopefully) have merged my last PR.
I should probably have used branches to sort this out, but I'm not very good with Git.
from react-native-image-gallery.
Exilz
commented on August 20, 2024
Shipped in 2.1.5, thanks.
from react-native-image-gallery.
Related Issues (20)
- Laggy when using setParams react navigation on page selected HOT 1
- how to stop photo from swiping vertically when scrolling horizontally
- Warning: componentWillMount/ componentWillReceiveProps deprecated HOT 1
- Example using image in storage
- Feature Request
- infinite scrolling feature
- This library is not MAINTAINED! HOT 7
- keyExtractor HOT 1
- detect when swiped at the last image
- Animated 'useNativeDriver' was not specified HOT 6
- Exit button is not defined by default? HOT 1
- page Scroll not working
- How can i get zoom scale
- zoom to area??
- initialPage doesn't work above index value of 9
- The Gallery seems to break after removing the last image HOT 1
- How to enlarge a picture without shrinking it？Could anyone do me a favor？
- Android header space
- How to zoom image via double tap.
- css part
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-native-image-gallery.