Comments (6)
Exilz
commented on May 13, 2024
Hi,
no, there is no workaround for this at the time.
We just added support the the `baseFontSize` prop, but we need to improve it to support the full range of text styling attributes. That would be much better.
It shouldn’t be hard to implement, most of the work is already there. In the meantime, I’m afraid you’re gonna have to use `tagsStyle`… or open a PR :)
… Le 5 oct. 2017 à 10:48, John Crisostomo ***@***.***> a écrit :
This is perfect for what I need, thanks for the good work. The only problem I have is that aside from baseFontSize, there doesn't seem to be an prop that I can use to change the color, fontFamily and the other attributes for all the text. Targeting each element using the tagsStyles work, but I just need a global ('*') rule to make all the text fit with the rest of my application.
Is there a workaround for this?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub <#25>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AIS1HvX2yxKjXDpZZ1pp0KWpvAc9hN0Kks5spJf0gaJpZM4PuvsT>.
from react-native-render-html.
commented on May 13, 2024
@Exilz Hahaha, fair enough, thanks. Yes, I have started reading the source code. I'm checking out how easy it is to implement. If I have the time, I'll definitely submit a PR for this. Thank you again!
from react-native-render-html.
Exilz
commented on May 13, 2024
Hi @johncrisostomo,
I'm currently working on this feature right now as I found out in one of our apps that this is actually a very critical feature to add.
The problem is that with nested texts, if your lovely contributors feed you something like
<strong><p>This is a text</p></strong>instead of
<p><strong>This is a text</strong></p>Your text won't be in bold if you supplied a <p> style in your tagsStyles prop.
This is because since the <p> is the deepest tag, its style will be the last to be applied.
The solution to this problem, rather than fiddling with the renderer and moving around the styles is this new baseFontStyle prop that would replace your typical <p> style.
Here is the WIP commit on the development branch. I'd love it if you could take a look at it and tell me what you think.
from react-native-render-html.
Exilz
commented on May 13, 2024
This landed in 3.5.0-rc.1. Since this release is quite important, testing would be appreciated !
from react-native-render-html.
commented on May 13, 2024
@Exilz Thanks so much for this! Sorry I have been busy the last few days, but will definitely test this out.
from react-native-render-html.
Exilz
commented on May 13, 2024
Looks like it's working properly. Please re-open an issue if it breaks something on your side.
from react-native-render-html.
Related Issues (20)
- Style is not working in img tags
- use a custom component for rendering HOT 4
- tagsStyles not working with custom font HOT 2
- Adjust the height container when inject a custom component in renders (image)
- other fonts don't work for children tags if you set font for parent HOT 1
- Failed prop type: Invalid prop `textDecorationColor` supplied to `Text`
- Render Error, maximum call stack size exceeded (native stack depth) HOT 2
- `<img>` embeds possibly not making use of `srcset` attribute resulting in blurry images HOT 3
- It is slow, it takes to import the components around 2 seconds
- Need Help for Break Lines Implementation HOT 1
- webView props mediaPlaybackRequiresUserAction not work HOT 2
- Not working android Realme device HOT 1
- defaultTextProps style overwrites renderers HOT 1
- Email or text is not showing proper way
- Slow navigate to a screen contains 12k words (including table)
- RTL is not working on p or div tag HOT 1
- the app crashes while rendering the table on Android. `table-plugin`
- How to disable Font Scaling in react-native-render-html v6 HOT 1
- Font family not working HOT 2
- React Native 0.74 (Bridgeless) Support HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-native-render-html.