Bug When selecting break on startup</cod

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

bug(DevTools): break on startup has no effect about melonds HOT 4 OPEN

axel7083 commented on May 20, 2024

bug(DevTools): break on startup has no effect

from melonds.

Comments (4)

axel7083 commented on May 20, 2024

@PoroCYon do you have some ideas ?

from melonds.

PoroCYon commented on May 20, 2024

sorry, don't really have time to look into it

could you try bisecting between 3ab752b and 31a7f53 to see which commit introduced the bug? there's been some refactoring going on so it could be something like that

from melonds.

RSDuck commented on May 20, 2024

from a glance it looks like GDB args are only passed in when the NDS object is created (

melonDS/src/frontend/qt_sdl/EmuThread.cpp

Line 145 in 10798c3

Config::GdbEnabled ? std::make_optional(gdbargs) : std::nullopt,

). They should be updated here as well

melonDS/src/frontend/qt_sdl/EmuThread.cpp

Line 295 in 10798c3

NDS->SPU.SetDegrade10Bit(static_cast<AudioBitDepth>(Config::AudioBitDepth));

Though then the setting should work under the condition that the setting was enabled during the construction of the NDS object (i.e. program startup or when switching between DS or DSi mode).

from melonds.

PoroCYon commented on May 20, 2024

Though then the setting should work under the condition that the setting was enabled during the construction of the NDS object (i.e. program startup or when switching between DS or DSi mode).

Yeah, this was also a limitation from before the refactoring.

from melonds.

Recommend Projects