Giter VIP home page Giter VIP logo

Comments (7)

krame505 avatar krame505 commented on June 21, 2024

from ablec.

krame505 avatar krame505 commented on June 21, 2024

After a little poking, it seems that there are a large number of flow problems related to pp and a few other attributes that just haven't yet caused any problems. I am going to go ahead and add explicit flowtypes for almost everything in ableC, which should (hopefully) finally pin these down for good, and also allow for the removal of all of our 'hackUnused' productions.

from ablec.

ericvanwyk avatar ericvanwyk commented on June 21, 2024

@tedinski - is there a status page somewhere the lists missing or incomplete parts of the MWDA? Can you create one otherwise?

@krame505 - thanks. It would be great to get this sorted out.

from ablec.

tedinski avatar tedinski commented on June 21, 2024

We have a tag for all flow analysis related issues: https://github.com/melt-umn/silver/issues?q=is%3Aissue+is%3Aopen+label%3AFlowAnalysis

The only missing thing should be the improvement I want to make to pattern matching. (Which shouldn't be anything missing, just an improvement?)

I started a "silver 0.4 release" project to track what I want to get done: https://github.com/melt-umn/silver/projects/3

from ablec.

ericvanwyk avatar ericvanwyk commented on June 21, 2024

With attribute sections, (.pp) for example, do these assume that the tree they are applied to is decorated? Is this why the MWDA now raises this error? We don't need env and returnType to compute pp.

I've fixed this (in #58), though there are additional things (as Lucas mentions) to be done.

from ablec.

krame505 avatar krame505 commented on June 21, 2024

Attribute sections can be applied to a decorated nonterminal or to an undecorated nonterminal, in which case it is implicitly decorated with no inherited attributes. The MWDA error is because something is messing up the flowtype on Expr for pp and causing it to depend on env and returnType anyway - this will be fixed as part of my flowtype audit, accessing pp via attribute section on an undecorated nonterminal is supposed to be OK.
This is only showing up now because Ted just recently implemented flowtype checking on attribute sections, the Expr flowtype issue on pp has probably been around for a while.

from ablec.

krame505 avatar krame505 commented on June 21, 2024

Fixed by #60

from ablec.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.