bug: `meltano config test` mixes a tap's stdout and stderr about meltano HOT 10 CLOSED

@edgarrmondragon I have raised a PR: #8225. Please review and let me know if any changes needs to be made.
Also, to run the pytest, I had to execute nox -t test. Is that the right way to run tests in this repository? I couldn't find anything related to running tests in https://docs.meltano.com/contribute/.
Thanks!

from meltano.

I logged dbt-labs/jaffle-shop-generator#110

from meltano.

hi @edgarrmondragon. I'm new to meltano repository and I would like to take this up. Please let me know if there's any other info I need to know to resolve this. Thanks!!

from meltano.

hi @edgarrmondragon. I'm new to meltano repository and I would like to take this up. Please let me know if there's any other info I need to know to resolve this. Thanks!!

Hi @raiatul14! Thanks for the interest in contributing. Are you familiar with Python's asyncio.subprocess.create_subprocess_exec or subprocess.run?

I ask because on a second look at this I'm unsure if we should redirect that tap's stderr to /dev/null as proposed or leave it as stderr=None (the default). I think the latter would result in mixing Meltano's logs with the taps stderr, but I don't know without testing it out.

from meltano.

@edgarrmondragon I haven't worked on asyncio.subprocess.create_subprocess_exec or subprocess.run before. But if you can guide me a bit then I can try to resolve it. Please let me know your thoughts. Thanks!

from meltano.

@raiatul14 It's ok, I think /dev/null is good enough for now. Do take a look at https://docs.meltano.com/contribute/prerequisites and feel free to fork the repo, create a branch, make sure tests in tests/meltano/core/test_plugin_test_service.py are still passing, and then create a PR and ping me when it's ready to be reviewed.

If there's any missing step, tool or instruction in the contributing guide do feel free to open separate PR(s) to add those 🙂

from meltano.

sure. Thanks for the instruction. I'll set it up

from meltano.

Also, to run the pytest, I had to execute nox -t test. Is that the right way to run tests in this repository?

@raiatul14 Yes, nox -t test is the right way. Are you interested in contributing a docs update for that? Ok if not, and logging an issue for someone else to document is good too.

from meltano.

@raiatul14 Yes, nox -t test is the right way. Are you interested in contributing a docs update for that? Ok if not, and logging an issue for someone else to document is good too.

sure. I'll either update the document(meltano/docs/docs/contribute/tests.md is where I need to update it, right?) or create an issue for someone else to work on.

from meltano.

sure. I'll either update the document(meltano/docs/docs/contribute/tests.md is where I need to update it, right?) or create an issue for someone else to work on.

@raiatul14 that's right. that's the best place to put it 👍

from meltano.