Comments (4)
Hey @haleemur, thanks for raising!
I think the problem is Meltano uses namespace
to identify custom plugins:
meltano/src/meltano/core/plugin/project_plugin.py
Lines 109 to 112 in b54c1c2
But otherwise the property is not really required.
That makes me think we may need to:
- Update the troubleshooting instruction in
meltano/src/meltano/core/project_plugins_service.py
Lines 81 to 84 in b54c1c2
or add the 'namespace' property to your plugin definition
. - Warn when
namespace
is missing, regardless of the type of plugin - Have a different, clearer, way of identifying custom plugins
Number 1 and 2 are probably the easiest.
from meltano.
Related:
- #3296, especially #3296 (comment)
- #3116
from meltano.
Thanks @edgarrmondragon,
I have a slight preference towards option 1 as its the simplest code change, and will suffice. If the documentation is improved according to #3116, maybe we should also update the warning message to point to it.
Option 2 feels a bit incorrect in the sense that the meltano install
command succeeds but the user sees a warning. I think it would just create unnecessary doubt for the end-user. So far, we're assuming that the error message is invoked at the right time, but its text does not direct the user towards all the potential root causes.
Option 3 sounds great, I just don't know yet what it would be.
from meltano.
On further thought, maybe meltano should test whether namespace
is present under the scenarios where it needs to be present (is a custom plugin), and emit specific instructions to the user to help resolve installation issues easily.
from meltano.
Related Issues (20)
- feature: System database support for AWS S3 HOT 6
- Replace use of flakeheaven with Ruff for flake8-errmsg
- docs: 404 on `/concepts/plugins/project` HOT 1
- Replace use of flakeheaven with Ruff for flake8-print
- Replace use of flakeheaven with Ruff for flake8-return
- feature: Capture run ID HOT 7
- Ruff: Enable flake8-pie, flake8-quotes and flake8-debugger
- feature: Make `pip` an explicit dependency of Meltano HOT 1
- bug: public discovery.yml is throwing 404 HOT 12
- bug: Environment variables are not passed from `.env` to the `pip install ...` subprocess
- Missing dependency wheels tracker
- feature: Make installation progress messages use logging instead of `click.echo` HOT 2
- bug: SingerMapper sets mapping configuration provided from env to null HOT 3
- bug: mysql-tap test returns Plugin configuration is invalid HOT 3
- feature: Add a `--run-id` option to `meltano el` similar to the one in `meltano run`
- bug: `meltano config <extractor> test` fails for SDK-based taps configured to use `BATCH` messages
- bug: Output of `meltano select <extractor> --list` is **visually** inconsistent between different Python 3.8-3.10 and 3.11+
- bug: Known upstream uv issues
- bug: Partial state causes failure when using a filesystem-based state backend
- bug: documentation for configuring plug-in python version HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from meltano.