Giter VIP home page Giter VIP logo

Comments (4)

edgarrmondragon avatar edgarrmondragon commented on June 11, 2024 1

Hey @haleemur, thanks for raising!

I think the problem is Meltano uses namespace to identify custom plugins:

if not self.inherit_from and namespace:
# When not explicitly inheriting, a namespace indicates an
# embedded custom plugin definition
self.custom_definition = PluginDefinition(

But otherwise the property is not really required.

That makes me think we may need to:

  1. Update the troubleshooting instruction in
    instruction = (
    "Try running `meltano lock --update --all` to ensure your plugins are "
    "up to date"
    )
    to include something like or add the 'namespace' property to your plugin definition.
  2. Warn when namespace is missing, regardless of the type of plugin
  3. Have a different, clearer, way of identifying custom plugins

Number 1 and 2 are probably the easiest.

from meltano.

edgarrmondragon avatar edgarrmondragon commented on June 11, 2024

Related:

from meltano.

haleemur avatar haleemur commented on June 11, 2024

Thanks @edgarrmondragon,

I have a slight preference towards option 1 as its the simplest code change, and will suffice. If the documentation is improved according to #3116, maybe we should also update the warning message to point to it.

Option 2 feels a bit incorrect in the sense that the meltano install command succeeds but the user sees a warning. I think it would just create unnecessary doubt for the end-user. So far, we're assuming that the error message is invoked at the right time, but its text does not direct the user towards all the potential root causes.

Option 3 sounds great, I just don't know yet what it would be.

from meltano.

haleemur avatar haleemur commented on June 11, 2024

On further thought, maybe meltano should test whether namespace is present under the scenarios where it needs to be present (is a custom plugin), and emit specific instructions to the user to help resolve installation issues easily.

from meltano.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.