Comments (3)
Thanks for the comments! I'm going to break them up into separate issues so they can be addressed and closed independently, but also responding here:
- For the (err) parameter, this makes sense in general. Worth discussing this more in depth in a separate issue, specifically when/which errors to pass in specific cases.
- I disagree that errors should be bubbled up rather than logged. Definitely for certain errors (like failure of operations that will be retried), I think it's important for the caller to be oblivious to this happening (notice that in the case of retries it's still a user tunable parameter). I do agree that some errors (e.g. out of memory) should bubble up as well.
- RE: console logging. Again, this makes sense to me. The one caveat is that with memcache you often want to silently ignore failures (as long as they are transient) but log them so you know. I'm happy allowing other logging mechanisms as long as it doesn't complicate the common case. Perhaps just a config var that's a logging function the user can replace? Would just default to
console.log
...
Anyway, I'll create some specific issue around these comments, please feel free to comment/discuss/send pull requests on those as well. Thanks!
from memjs.
Marking as duplicate since I broke this into two separate issues.
from memjs.
Of course, thanks!
On Jun 19, 2012 10:12 PM, "Amit Levy" <
[email protected]>
wrote:
Marking as duplicate since I broke this into two separate issues.
Reply to this email directly or view it on GitHub:
#1 (comment)
from memjs.
Related Issues (20)
- timeout but failed to retry until restarting program HOT 28
- Is it possible to use from the browser? HOT 1
- Operation timeouts do not work as expected HOT 3
- How to clear memcached server from nodejs? HOT 2
- Denial of Service vulnerability HOT 1
- memJS terminates connection to coherence HOT 1
- Feature: Key wrapper
- Get without callback returns incorrect signature HOT 2
- Possibility to get all errors from server
- Do we have option to use limit and offset HOT 1
- Application exits if memcached server restarts HOT 1
- Can we delete many keys? HOT 1
- unix socket support HOT 1
- MCRouter issue HOT 3
- Add node autodiscovery HOT 1
- TLS support for memjs
- Sporadic bursts of error: socket timed out waiting on response
- Trying an operation after calling `.quit()` doesn't trigger any errors HOT 3
- Possible bug in signature check HOT 2
- Possible support for ASCII protocol? HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from memjs.