Comments (11)
Thank you so much @katarinasupe @as51340. Much appreciated.
Unrelated but I am not sure how the integration with kuzu will go. I am happy to contribute back if I run into issues of course.
from gqlalchemy.
@jpmmcneill Just to check is 2.3.0 good enough for you? We are trying to support all versions compatible with 2.3.0. This means that versions between 2.0 and 2.3 may not work.
from gqlalchemy.
@as51340 I think>=2.3 is fine. Pydantic is 2.5 now and it is a well resourced project so I cannot imagine it would be difficult for users to update a few minor versions once on v2
from gqlalchemy.
#278 this is the PR that added this requirement. I imagine it was a mistake to pin it to a patch based on the context of this pr.
from gqlalchemy.
Hi @jpmmcneill, glad to hear you like the project 😄 What are you working on for your hobby project?
We did discussed making it minor or patch, and by your comment, I could say we didn't think it well enough. But, to allow users to use v1 and v2 pydantic in their projects (since users were looking for both), we found a workaround of importing pydantic.v1 in projects where you'd like to use v1 (e.g. - https://github.com/memgraph/gqlalchemy/pull/278/files#diff-09f64bc569acbae4645862ef2ab8e09608f050548d746e0ad57f8a457e305584R17). We do this now in GQLAlchemy, although v2 of Pydantic is installed with the library. Does this work for you?
from gqlalchemy.
@katarinasupe hey, thanks for the response. My hobby project is using Kuzu as a backend for an application that stores data about fantasy worlds (ideally useful for those of us who run tabletop role playing games like Dungeons and Dragons).
My point is that I very much doubt that GQLalchemy depends on pydantic 2.3.0 exactly, and this pinning discourages me from using the package. I'd need to base my version of pydantic entirely on. gqlalchemy, and then some other packages that are dependent on pydantic would often not be installable.
Do you know the context around why this pin was made? To be honest, pydantic is a widely adopted package, so I do not think there is a risk in unpinning this dependendy.
from gqlalchemy.
Cool project! 😄
@as51340, do you remember why we used 2.3.0 as an exact version for Pydantic? Was there any specific reason?
from gqlalchemy.
Because we had a request to upgrade pydantic v2. I will try to improve this
from gqlalchemy.
@jpmmcneill You are right, gqlalchemy doesn't need to depend exactly on 2.3.0. However, since the main goal was just to support easy migration from pydantic.v1 to v2, it did its job. I will try up improve this behavior today and @katarinasupe will let you know if it's been fixed.
from gqlalchemy.
I don't know but am also very interested, don't know if anyone had experimented with Kuzu and Gqla yet. Looking forward to see results!
from gqlalchemy.
Glad to help @jpmmcneill! I am definitely interested in seeing how the integration will go. If you haven't, you can join our Discord for quicker communication and feedback 😄
from gqlalchemy.
Related Issues (20)
- Add SHOW BUILD INFO query to query builder
- Keep MAGE procedures up to date HOT 1
- Upgrade to pydantic v2 HOT 10
- Migrate docs from Memgraph docs repo to GQLAlchemy repo
- [BUG] Inclusion of the docker dependency bring in pywin32 which has an outstanding vulnerability HOT 1
- [BUG] Relax neo4j dependency version
- Expand LOAD CSV with remote CSV location HOT 2
- [BUG] Missing Cypher operators HOT 2
- Markdown lists in the documentation are not always rendered in the correct way
- [BUG] : undefined symbol: `EVP_PKEY_base_id` (in `mgclient.cpython-39-x86_64-linux-gnu.so`) HOT 19
- Missing documentation section on execute()
- GQLAlchemy can't be installed on Windows with Python 3.11 HOT 2
- Propagate autocommit flag from pymgclient to gqlalchemy
- Support: Confusion over usage of `Field` class HOT 8
- Add IS NOT NULL to query builder
- undefined symbol: SSL_get1_peer_certificate HOT 6
- Docs needed for connecting to Memgraph from gqlalchemy HOT 1
- [BUG] CSVLocalFileSystemImporter can't load datetime from csv HOT 17
- [Feature Request] Please allow add edge properties in Loaders HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gqlalchemy.