Giter VIP home page Giter VIP logo

Comments (4)

mendhak avatar mendhak commented on August 18, 2024

Hello thanks for the pull request. Having the IntroJs instance in the callback will be useful.

Can you explain - What is the advantage of passing the scope to the callback method? From what I can see, the callback will always be in the current controller's scope anyway, so the $scope is visible.

from angular-intro.js.

ilovett avatar ilovett commented on August 18, 2024

I believe the scope passed is actually the directive's scope, not the controller

from angular-intro.js.

mendhak avatar mendhak commented on August 18, 2024

Thanks, I've merged it in, updated the demo page too. It's now in release 1.1.3

from angular-intro.js.

ilovett avatar ilovett commented on August 18, 2024

Thanks, cheers

from angular-intro.js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.