Token refreshing issue about spotify.py HOT 4 CLOSED

I hope that makes sense... I'd be happy to do a pull request. In order to do that I need to know if there is some other usecase HttpClient.get_bearer_info is handling (besides refreshing the token) or is the function just broken.

from spotify.py.

I created a commit here to explain what I'm trying to say.
micahdlamb@2a62f22

This seems like a better way to handle the token refreshing. Its a lot simpler and doesn't continually refresh the token when I hold onto User objects for a long time.

I'm not making a pull request as there are api breaking changes and I'm not sure how you would want to handle that. Let me know what you think...

from spotify.py.

Nice catch!

I was under the impression that refresh tokens expired after some time, but I just checked the Spotify web API guides and I see no mention of this.

This is certainly a much cleaner solution to handling User access token refreshing.

I'm not making a pull request as there are api breaking changes and I'm not sure how you would want to handle that. Let me know what you think...

The library is semantically versioned and currently it hasn't reached major revision one yet (its still at major zero) so breaking changes are perfectly fine until then.

Would you like to PR this in?
I'll likely do it tomorrow otherwise :)

from spotify.py.

Great! I'll try to make a pull request tonight.

from spotify.py.