Exit code is zero when parsing fails about oas-kit HOT 4 CLOSED

Fantastic! All I needed was an update. :)

I also really appreciate the advice about the testRunner. And most of all, thank you for the quick response! I'm about to modify a bunch of services and I'm very, very happy to know this before I start. 🙇

from oas-kit.

Thanks for the report, will take a look at both issues.

from oas-kit.

Can I check which version you're running?

It looks like that got fixed in commit 72bd25b - which is included in v2.11.13

node swagger2openapi.js test/missing-info/swagger.yaml && echo ok
Error: (Patchable) info object is mandatory
    at fixInfo (/home/mike/nodejs/swagger2openapi/index.js:1129:27)
    at /home/mike/nodejs/swagger2openapi/index.js:1313:9
    at new Promise (<anonymous>)
    at convertObj (/home/mike/nodejs/swagger2openapi/index.js:1198:28)
    at /home/mike/nodejs/swagger2openapi/index.js:1376:13
    at new Promise (<anonymous>)
    at convertStr (/home/mike/nodejs/swagger2openapi/index.js:1362:28)
    at /home/mike/nodejs/swagger2openapi/index.js:1415:17
    at FSReqWrap.readFileAfterClose [as oncomplete] (fs.js:511:3)

You might get clearer output from using testRunner -n in your CI process, and this has the benefit that it actually runs the validator on the converted output (swagger2openapi itself does almost nothing when given an input file which is already in OpenAPI 3.0.x format):

node testRunner.js -v -n test/missing-info/swagger.yaml && echo ok
Gathering...
Error: (Patchable) info object is mandatory 

Failures:
Converter failed swagger.yaml

Tests: 0 passing, 1 failing, 0 warnings

In both cases above ok is not echoed, as the exit code is non-zero.

from oas-kit.

No problem, please let me know if you hit any other issues.

from oas-kit.