Giter VIP home page Giter VIP logo

Comments (7)

npretto avatar npretto commented on June 3, 2024 1

This has been fixed by #41399, a release should be made soon

from metabase.

Tony-metabase avatar Tony-metabase commented on June 3, 2024 1

@saadbahir we should be releasing 49.6 today so expect a couple of more hours for it to be available

from metabase.

saadbahir avatar saadbahir commented on June 3, 2024

I am encountering the same problem

Seems like there are a lot of issues in v49

from metabase.

saadbahir avatar saadbahir commented on June 3, 2024

Hello @kulyk

Sorry to ping you like this but I wondered whether your PR right here may have introduced this regression

from metabase.

saadbahir avatar saadbahir commented on June 3, 2024

@deniskaber thank you for triaging this ticket!

If you have any suggestion that we can use to "force" the tab selection when we open the embed (using some sdk or post message), I would welcome it very much!

from metabase.

npretto avatar npretto commented on June 3, 2024

To add some context, I think this is what's going on:
#41399 doesn't render <DashboardTabs> unless we have tabs, <DashboardTabs calls useDashboardTabs which dispatches initTabs before we have the tabs loaded, causing the code to think we're selecting an invalid tab on the reducer and therefore setting the selected tab to null

metabase/frontend/src/metabase/dashboard/actions/tabs.ts

Lines 569 to 578 in 5a7360d

builder.addCase(initTabs, (state, { payload: { slug } }) => {
const { prevTabs } = getPrevDashAndTabs({ state });
const idFromSlug = getIdFromSlug(slug);
const tabId =
idFromSlug && prevTabs.map(t => t.id).includes(idFromSlug)
? idFromSlug
: prevTabs[0]?.id ?? null;
state.selectedTabId = tabId;

from metabase.

saadbahir avatar saadbahir commented on June 3, 2024

Thank you @npretto for your quick feedback!

This is a vital fix for us as we use Metabase Embedding at scale and this is currently breaking a lot of our workflows

Do you please have any timeline on the release? are we talking hours or days?
Thank you for your help!

from metabase.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.