Need a way to minimize duplication when using icons between react and angular about metabase HOT 5 CLOSED

My main thought is it seems like a lot of brain damage to keep two distinct ways to insert icons around.
Why are icons both react and angular components?

from metabase.

Its really the unfortunate side effect of the fact that you can't easily use angular directives and react components inside of one another without some tomfoolery.

from metabase.

Basically the options for BrainDamage(TM) as far as I can tell are:

• have two distinct places where the icons shapes are defined, and two different ways of using them (our current version)
• have two different ways of using a single source of truth for icons
• only be able to use certain icons in angular or react (problematic for checks or close)
• burn everything and use blue hyperlinks

my main reason for raising this was that before I start adding more icons in for things like charting options, etc that we think through what we could do to prevent duplication of what the shapes are supposed to look like, and how we use them to the best of our ability.

from metabase.

yeah, this looks fine to me 👍

over time i'm sure we could eventually find a way to make the icons reusable between both angular and react (or we would just abandon one for the other), but until then this makes sense to me.

my only suggestion is that in the angular directive, don't use templateUrl, just use template and put the template directly in the directive. that's faster performance wise and its easier when you are coding because you don't need to switch files.

from metabase.

That makes sense to me and I agree r.e. template vs templateUrl. Ideally this is a situation we won't be in for a long time.

from metabase.