When reseting your password, the link shouldn't work if the token is expired (should redirect to forgot password with an explanatory message) about metabase HOT 12 CLOSED

+1

from metabase.

This needs a new error message HTML page to display when the token is invalid / expired. When that's done, we can introduce a new API endpoint to check to see if a token is expired, then write new frontend code to hit that endpoint, and show the new error page if needed, or otherwise show the appropriate change password form.

from metabase.

cool. @mazameli you want to take a quick pass at UX for this one and let us know how you think the frontend should respond?

basic problem is that someone loads up a url like mymetabase.com/auth/reset/:reset_token and the token is expired. what should the user see when this happens?

from metabase.

?

from metabase.

Do we know if a token is invalid vs expired?

from metabase.

Yup, we track expiration_date

from metabase.

@mazameli Can you assign back to me once the designs are g2g

from metabase.

@camsaul will do

from metabase.

Mockup: https://www.dropbox.com/s/zh1q21iesd53uli/expired_password_reset_link_v1.png?dl=0
Sketch file: https://www.dropbox.com/s/qhbz8320pqu7ms3/expired_password_reset_link_v1.sketch?dl=0

from metabase.

can we also include a 404 or message when the token isn't in the system?

from metabase.

it already does that, it displays an �invalid token� message

On Sep 25, 2015, at 5:31 PM, Sameer Al-Sakran [email protected] wrote:

can we also include a 404 or message when the token isn't in the system?

�
Reply to this email directly or view it on GitHub.

from metabase.

Cool

On Friday, September 25, 2015, Cam Saül [email protected] wrote:

it already does that, it displays an �invalid token� message

On Sep 25, 2015, at 5:31 PM, Sameer Al-Sakran <[email protected]
javascript:_e(%7B%7D,'cvml','[email protected]');> wrote:

can we also include a 404 or message when the token isn't in the system?

�
Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHub
#594 (comment)
.

from metabase.