[Add Cluster as Release] Plug-in adds extra tracks to album about picard-plugins HOT 9 CLOSED

@CyberSkull can you still reproduce this? I've fixed this in metabrainz/picard@50bc075 (without updating the version number :/), so I'm unsure whether you were just using an old 0.5 version of the plugin or if the fix was not correct.

from picard-plugins.

I downloaded and installed the version of the plugin you linked to, and it does not fix the issue. I added an album that has 6 volumes, then added an album with 1 volume, and the additional tracks were still appended to the second album.

• OS: Mac OS X 10.10.1
• Picard 1.3.2
• Add Cluster as Release 0.5 (50bc075)

from picard-plugins.

You actually need the plugin from at least the commit after that one because I forgot the parantheses around the method call which cleared the internal state that's responsible for this bug. You can simply take the plugin from current master (https://raw.githubusercontent.com/musicbrainz/picard/master/contrib/plugins/addrelease.py) which has them. Sorry for not being clear about that in the previous comment.

from picard-plugins.

using an old 0.5 version of the plugin or if the fix was not correct.

Wasn't the version updated after changes ?

from picard-plugins.

Seems to be fixed in the master branch (though you should update the version number 😉).

from picard-plugins.

I've now incremented the version number in picards repository. What is the proper way to get this change into this repository? Manually applying that change, or is there a script that I can run that automatically gets the latest changes from picards repo?

from picard-plugins.

You have to copy the plugin to the picard-plugins repository manually.

I think the proper fix would be to finally do a git rm -r contrib/plugins/ and use only picard-plugins. For convenience we could add the plugins repository as a git submodule, if people want this.

from picard-plugins.

I've now opened #11 to update the plugin included here.

+1 to @phw s suggestion.

from picard-plugins.

I think the proper fix would be to finally do a git rm -r contrib/plugins/ and use only picard-plugins. For convenience we could add the plugins repository as a git submodule, if people want this.

I agree too.

from picard-plugins.