Comments (4)
Respect to the second point, I have used C89 mostly because I was wondering MetaCall may work with cases like COBOL migrations. For very old computers, maybe this standard may be needed. I don't know if this restriction does pay off. I think it is too restrictive and makes the code much more uglier. Most runtimes won't work anyway with that kind of old computers so it does not make sense to continue like that.
In the first point you are right, I have avoided goto
s for no real reason, just a bad practice, and error handling is basically nonexistent.
This happens in the whole codebase. If you start refactoring the Python Loader, it can be a great advance. Later on we can start moving to the Core. Respect to the commit you listed, yes, that's the proper way of doing it, feel free to refactor.
The only thing I request to you is to validate that all tests work and pass AddressSanitizer and Valgrind to verify you do not create new memory leaks, specially in fail-path tests. We just have added new PR and Issue templates, and also you can check here how to enable Asan and Valgrind for testing: https://github.com/metacall/core/blob/develop/docs/README.md#63-debugging
from core.
Great! I'll get started on the refactor.
from core.
@Encrylize Are you going to continue with this or can I close the issue?
from core.
@viferga Let's just close it for now. :)
from core.
Related Issues (20)
- Improve rs_port HOT 3
- Failed to compile Metacall with the Python loader because of conflicting types HOT 1
- Empty buffer case for go port HOT 2
- The `node_loader` crashes when a Javascript Promise is rejected HOT 3
- Sanitizer Fails on macOS HOT 1
- Clang Warning on macOS HOT 1
- Unable to build metacall in Visual Studio 2019 HOT 1
- MacOS CI TODOs HOT 2
- Build fails in macOS after adding C support HOT 1
- Implement Benchmarking CI HOT 1
- macOS CI fails with C HOT 2
- Update `rs_loader` to the latest Rust compiler version
- macOS build CI fails with netcore7
- segmentation fault HOT 2
- Issue with java tests in windows HOT 4
- unable to deploy once have package.json HOT 5
- Importing torch crashed when metacall is imported first. HOT 2
- Windows CI tests fail with Python on Release mode
- Review Windows Benchmark Issue and possible improvement of gh-pages HOT 6
- Sandbox Plugin System Design HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from core.