Giter VIP home page Giter VIP logo

Comments (4)

viferga avatar viferga commented on August 30, 2024

Respect to the second point, I have used C89 mostly because I was wondering MetaCall may work with cases like COBOL migrations. For very old computers, maybe this standard may be needed. I don't know if this restriction does pay off. I think it is too restrictive and makes the code much more uglier. Most runtimes won't work anyway with that kind of old computers so it does not make sense to continue like that.

In the first point you are right, I have avoided gotos for no real reason, just a bad practice, and error handling is basically nonexistent.

This happens in the whole codebase. If you start refactoring the Python Loader, it can be a great advance. Later on we can start moving to the Core. Respect to the commit you listed, yes, that's the proper way of doing it, feel free to refactor.

The only thing I request to you is to validate that all tests work and pass AddressSanitizer and Valgrind to verify you do not create new memory leaks, specially in fail-path tests. We just have added new PR and Issue templates, and also you can check here how to enable Asan and Valgrind for testing: https://github.com/metacall/core/blob/develop/docs/README.md#63-debugging

from core.

jfblomgren avatar jfblomgren commented on August 30, 2024

Great! I'll get started on the refactor.

from core.

viferga avatar viferga commented on August 30, 2024

@Encrylize Are you going to continue with this or can I close the issue?

from core.

jfblomgren avatar jfblomgren commented on August 30, 2024

@viferga Let's just close it for now. :)

from core.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.