Giter VIP home page Giter VIP logo

Comments (3)

GoogleCodeExporter avatar GoogleCodeExporter commented on July 29, 2024
Here's the source for MetacelloGoferPackage>>matches: that looks like it fixes 
Mariano's ConfigurationOfNautilus problem and the Moose ConfigurationOfGlamour 
issue that I ran into (in retrospect, it looks like the Moose bug was a 
consequence of some additional changes I had made to the system for 
1.0-beta.32...):

matches: aLoadableReference
    "does Monticello-style #versionInfoFromVersionNamed: matching"

    | pFilename refName char |
    ((pFilename := self packageFilename) == nil or: [ self name = self packageFilename ])
        ifTrue: [ ^ super matches: aLoadableReference ].
    aLoadableReference name = pFilename
        ifTrue: [ ^ true ].
    (aLoadableReference name beginsWith: pFilename)
        ifFalse: [ ^ false ].
    refName := aLoadableReference packageName.
    refName = pFilename
        ifTrue: [ ^ true ].
    pFilename size < refName size
        ifTrue: [ 
            (refName beginsWith: pFilename)
                ifFalse: [ ^ false ].
            (char := pFilename at: pFilename size) ~= $-
                ifTrue: [ char := refName at: pFilename size + 1 ] ]
        ifFalse: [ 
            (pFilename beginsWith: refName)
                ifFalse: [ ^ false ].
            (char := refName at: refName size) ~= $-
                ifTrue: [ char := pFilename at: refName size + 1 ] ].
    ^ char = $. or: [ char = $- ]

The Metacello tests all pass (they didn't with the earlier patch), so this one 
should be safe to use ... I'll be working this into a release in the next day 
or so ...

Original comment by [email protected] on 24 Feb 2012 at 1:17

  • Added labels: ****
  • Removed labels: ****

from metacello-wiki.

GoogleCodeExporter avatar GoogleCodeExporter commented on July 29, 2024
The fix plus additional tests committed to an "issue178 branch":

  Metacello-MC.issue178-dkh.549
  Metacello-TestsMC.issue178-dkh.170

in http://seaside.gemstone.com/ss/metacello

Original comment by [email protected] on 24 Feb 2012 at 1:23

  • Added labels: ****
  • Removed labels: ****

from metacello-wiki.

GoogleCodeExporter avatar GoogleCodeExporter commented on July 29, 2024

Original comment by [email protected] on 19 May 2012 at 7:41

  • Added labels: Milestone-1.0-beta.31.2
  • Removed labels: Milestone-1.0-beta.31.1.1

from metacello-wiki.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.