Comments (3)
Here's the source for MetacelloGoferPackage>>matches: that looks like it fixes
Mariano's ConfigurationOfNautilus problem and the Moose ConfigurationOfGlamour
issue that I ran into (in retrospect, it looks like the Moose bug was a
consequence of some additional changes I had made to the system for
1.0-beta.32...):
matches: aLoadableReference
"does Monticello-style #versionInfoFromVersionNamed: matching"
| pFilename refName char |
((pFilename := self packageFilename) == nil or: [ self name = self packageFilename ])
ifTrue: [ ^ super matches: aLoadableReference ].
aLoadableReference name = pFilename
ifTrue: [ ^ true ].
(aLoadableReference name beginsWith: pFilename)
ifFalse: [ ^ false ].
refName := aLoadableReference packageName.
refName = pFilename
ifTrue: [ ^ true ].
pFilename size < refName size
ifTrue: [
(refName beginsWith: pFilename)
ifFalse: [ ^ false ].
(char := pFilename at: pFilename size) ~= $-
ifTrue: [ char := refName at: pFilename size + 1 ] ]
ifFalse: [
(pFilename beginsWith: refName)
ifFalse: [ ^ false ].
(char := refName at: refName size) ~= $-
ifTrue: [ char := pFilename at: refName size + 1 ] ].
^ char = $. or: [ char = $- ]
The Metacello tests all pass (they didn't with the earlier patch), so this one
should be safe to use ... I'll be working this into a release in the next day
or so ...
Original comment by [email protected]
on 24 Feb 2012 at 1:17
- Added labels: ****
- Removed labels: ****
from metacello-wiki.
The fix plus additional tests committed to an "issue178 branch":
Metacello-MC.issue178-dkh.549
Metacello-TestsMC.issue178-dkh.170
in http://seaside.gemstone.com/ss/metacello
Original comment by [email protected]
on 24 Feb 2012 at 1:23
- Added labels: ****
- Removed labels: ****
from metacello-wiki.
Original comment by [email protected]
on 19 May 2012 at 7:41
- Added labels: Milestone-1.0-beta.31.2
- Removed labels: Milestone-1.0-beta.31.1.1
from metacello-wiki.
Related Issues (20)
- Metacello doesn't use local mczs during bootstrap HOT 2
- odd spec passes validation HOT 1
- MetacelloPackageSpec>>packageRespository should be eliminated
- Critical Warning for missing versionString in baseline project reference HOT 1
- Mechanism in validator to identify departures from recommendations for specifying versions HOT 1
- note: method in ConfigurationOf for including in-line comments HOT 1
- scripting API suggestions HOT 1
- Tutorial out-of-date for Pharo 1.4
- should have #ensureCoreMetacello for absolute minimal load HOT 1
- record: does not faithfully report result of load: when project packages are present
- validator ought to issue critical warnings when versionString in version pragma doesn't match parsed version printString HOT 2
- MetacelloConfigTemplate doesn't have any instance template methods
- Version generated from a baseline can have empty package versions in a platform-specific section HOT 1
- Replace Squeaksource with Chilean mirror when its down HOT 1
- nested version fail MetacelloToolBox validation HOT 4
- github zip download failures due to filesystem issues HOT 2
- Bootstrapping broken on Squeak 4.4, because URL redirects do not seem to work for monticello. HOT 2
- Metacello toolbox proposal
- get wrong reference to load a package version such as '.1', '.11' developed by the same guy HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from metacello-wiki.