Giter VIP home page Giter VIP logo

Comments (22)

dhellmann avatar dhellmann commented on July 24, 2024 1

There is some additional guidance on https://github.com/github/renaming suggesting that if we wait a little bit, GitHub will provide better tools to make the transition go more smoothly.

from metal3-docs.

maelk avatar maelk commented on July 24, 2024 1

This could be tried on a repo that is not much used, such as IPAM ?

from metal3-docs.

dhellmann avatar dhellmann commented on July 24, 2024

It would be good to handle the branch renaming in all of our repos quickly to minimize disruption. I imagine a couple of us with admin privileges could go through and do that. Does the k8s community have a set of instructions worked out?

What other changes would we need to make? Does CI need to be reconfigured at the same time?

from metal3-docs.

demonCoder95 avatar demonCoder95 commented on July 24, 2024

It's a questionable move by Github and others in my opinion, changing terminology will not have the desired affect, at all. These are problems of perception and human behaviors, not words. It will only cause software breakage all over the place, adding to the already humongous mess of terminology that has already been in place since forever.

However, the proposed changes look reasonable. So, LGTM. +1

from metal3-docs.

maelk avatar maelk commented on July 24, 2024

This is also a work in progress on the K8S side. They are starting a work group on this AFAIK. so no instructions yet. The prow config has quite some references to master, especially for container images. They'll need to be changed once all the new images are created. We will also need to change all container images references in all repos (in hack and deploy/config folders).
Jenkins will also need to be reconfigured, that's something that we will take care of when the branch change is done.

I would propose to proceed the following way for the branch renaming :

  • create the main branch in all repositories
  • modify all references to master, in CI and in all repos, specifically for container images
  • modify the default branch
  • Fix CI and Jenkins
  • remove master branch

from metal3-docs.

dhellmann avatar dhellmann commented on July 24, 2024

We may also need to follow the instructions for setting the new default branch. https://docs.github.com/en/github/administering-a-repository/setting-the-default-branch

from metal3-docs.

metal3-io-bot avatar metal3-io-bot commented on July 24, 2024

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues will close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle stale

from metal3-docs.

maelk avatar maelk commented on July 24, 2024

/remove-lifecycle stale

from metal3-docs.

metal3-io-bot avatar metal3-io-bot commented on July 24, 2024

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues will close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle stale

from metal3-docs.

maelk avatar maelk commented on July 24, 2024

/remove-lifecycle stale

from metal3-docs.

fmuyassarov avatar fmuyassarov commented on July 24, 2024

It seems that Github has made it easy now to rename the existing branch: https://github.com/github/renaming. Based on that document, the list of the things that will be taken care by Github while renaming is:

  1. Re-target any open pull requests
  2. Update any draft releases based on the branch
  3. Move any branch protection rules that explicitly reference the old name
  4. Update the branch used to build GitHub Pages, if applicable
  5. Show a notice to repository contributors, maintainers, and admins on the repository homepage with instructions to update local copies of the repository
  6. Show a notice to contributors who git push to the old branch
  7. Redirect web requests for the old branch name to the new branch name
  8. Return a "Moved Permanently" response in API requests for the old branch name

from metal3-docs.

furkatgofurov7 avatar furkatgofurov7 commented on July 24, 2024

ref: https://www.kubernetes.dev/resources/rename/

from metal3-docs.

metal3-io-bot avatar metal3-io-bot commented on July 24, 2024

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues will close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle stale

from metal3-docs.

furkatgofurov7 avatar furkatgofurov7 commented on July 24, 2024

/remove-lifecycle stale

from metal3-docs.

metal3-io-bot avatar metal3-io-bot commented on July 24, 2024

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues will close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle stale

from metal3-docs.

fmuyassarov avatar fmuyassarov commented on July 24, 2024

/remove-lifecycle stale

from metal3-docs.

metal3-io-bot avatar metal3-io-bot commented on July 24, 2024

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues will close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle stale

from metal3-docs.

fmuyassarov avatar fmuyassarov commented on July 24, 2024

/lifecycle active

from metal3-docs.

Rozzii avatar Rozzii commented on July 24, 2024

/triage accepted

from metal3-docs.

metal3-io-bot avatar metal3-io-bot commented on July 24, 2024

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues will close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle stale

from metal3-docs.

metal3-io-bot avatar metal3-io-bot commented on July 24, 2024

Stale issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle stale.

/close

from metal3-docs.

metal3-io-bot avatar metal3-io-bot commented on July 24, 2024

@metal3-io-bot: Closing this issue.

In response to this:

Stale issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle stale.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

from metal3-docs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.