Sync a set of labels placed on a BMH to the corresponding K Node object about metal3-docs HOT 13 CLOSED

Great. I'll put together a proposal.

from metal3-docs.

@maelk @dhellmann PTAL.

from metal3-docs.

I like the idea of doing this. I'm not sure about using a command line flag to configure it, but we can work through that.

Is there any reason to limit which labels are copied? What would happen if we just take them all?

from metal3-docs.

Is there any reason to limit which labels are copied? What would happen if we just take them all?

The primary concern is that we may be stepping on labels that are managed by some other entity (this was brought up in the CAPI issue linked). Here CAPM3 would own the set of labels that match the prefix.

Also, the ask is for synchronization and not just a one time copy from BMH to Node on creation; that is, if a label (say my-prefix.metal3.io/rack) was accidentally removed from the Node, CAPM3 would reapply it; similarly, if the user added/removed a label on a BMH, CAPM3 would ensure the Node was updated appropriately.

from metal3-docs.

I also think this would be a very valuable feature for CAPM3. Would you mind starting a proposal on this ?

from metal3-docs.

If we have consensus that this is a good feature to have, then I can definitely write up a proposal.

from metal3-docs.

Yes, I think we definitely want this. We've been looking at how to do something similar with the hardware-classification-controller output.

It would be ideal if this was a new controller in capm3, so we could import the code into capbm downstream. If not a controller, then maybe a library function we could invoke separately.

from metal3-docs.

@dhellmann @maelk PTAL:
https://docs.google.com/document/d/1qMCkggaLGQLHNPnEVGYjpabSrO-DTvSsr8uIW06W0ck/edit?usp=sharing

from metal3-docs.

@Arvinderpal if that document is ready for review, please move it to a pull request on this repository.

from metal3-docs.

@dhellmann #149

from metal3-docs.

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues will close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle stale

from metal3-docs.

Stale issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle stale.

/close

from metal3-docs.

@metal3-io-bot: Closing this issue.

from metal3-docs.