Crash [AVAssetReaderVideoCompositionOutput copyNextSampleBuffer] about videoio HOT 10 CLOSED

Unable to reproduce, nevertheless, the current cancellation logic seems error-prone. Tweaked the implementation, you can try again using this commit to see if the issue goes away: f0fc524

Note:

• AssetExportSession is not thread-safe, do not access the same instance in different threads.
• f0fc524 ensures the completion handler will be called after you cancel the export session. If the export session is successfully cancelled AssetExportSession.Error.cancelled is reported. If the cancel happens too late that the export session is finishing its work, a successful export is reported.

from videoio.

@YuAo thanks! Updating internal specs.

from videoio.

@YuAo could you please put podspec file in the repo? I cannot install via CocoaPods pod 'VideoIO', :git => 'https://github.com/MetalPetal/VideoIO.git', :commit => 'f0fc524' since podspec is not available.

from videoio.

@larryonoff You can always use your own podspec file with CocoaPods. For example:

pod 'VideoIO', :podspec => 'https://gist.githubusercontent.com/YuAo/5607e47faa4ad7ddf2bf101605eb7455/raw/e10e7463de9db291b3d2f543dfc40e329f0b8fe7/VideoIO.head.podspec.json'

from videoio.

@YuAo thanks! I use your gist for the moment :)

from videoio.

@YuAo it looks that there're less crashes according to our internal QA.

from videoio.

@larryonoff Do you think the problem is fixed? Or it just happens lesser?

from videoio.

@YuAo I'm not sure yet. We're still testing our app. But more testing is planned next week.

At least concrete crash report in Crashlytics is gone.

from videoio.

@larryonoff Happy to hear that, keep me posted.

from videoio.

@YuAo sure! thanks for the libraries and support.

from videoio.