Giter VIP home page Giter VIP logo

Comments (4)

googletorp avatar googletorp commented on August 16, 2024

Hey @mglaman, please let me know what you think about this, the code is pretty simple for this so made a PR in the hopes that you agree with me.
Thanks for all the work maintaining this.

from drupal-check.

rimi-itk avatar rimi-itk commented on August 16, 2024

Thanks for #278, @googletorp.

However, it may be a better solution to make it possible include some configuration file, e.g. phpstan.neon (in the project root), when running drupal-check (cf. https://github.com/mglaman/drupal-check#rollback-update-to-phpstan-level-2-for-deprecation-analysis). Any thoughts on this, @mglaman?

from drupal-check.

mglaman avatar mglaman commented on August 16, 2024

However, it may be a better solution to make it possible include some configuration

Please, just use PHPStan directly then. This package is meant to be an opinionated quick scan. Annotating array types can be annoying, but it helps fix buggy code.

from drupal-check.

googletorp avatar googletorp commented on August 16, 2024

@mglaman I agree in general that annotating array types is a great thing, but with Drupal use of render and form arrays, you get a bunch or warnings every time you extend core, which seems to defeat the purpose of writing clean code, if the framework you are building upon doesn't follow the same standards.

Can you offer some guidance on how to use this feature without getting overwhelmed by errors coming from Drupal Core?

from drupal-check.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.