Comments (4)
Hey @mglaman, please let me know what you think about this, the code is pretty simple for this so made a PR in the hopes that you agree with me.
Thanks for all the work maintaining this.
from drupal-check.
Thanks for #278, @googletorp.
However, it may be a better solution to make it possible include some configuration file, e.g. phpstan.neon
(in the project root), when running drupal-check
(cf. https://github.com/mglaman/drupal-check#rollback-update-to-phpstan-level-2-for-deprecation-analysis). Any thoughts on this, @mglaman?
from drupal-check.
However, it may be a better solution to make it possible include some configuration
Please, just use PHPStan directly then. This package is meant to be an opinionated quick scan. Annotating array types can be annoying, but it helps fix buggy code.
from drupal-check.
@mglaman I agree in general that annotating array types is a great thing, but with Drupal use of render and form arrays, you get a bunch or warnings every time you extend core, which seems to defeat the purpose of writing clean code, if the framework you are building upon doesn't follow the same standards.
Can you offer some guidance on how to use this feature without getting overwhelmed by errors coming from Drupal Core?
from drupal-check.
Related Issues (20)
- drupal-check conflicts with phpstan/extension-installer HOT 2
- Drupal check errors on baseFieldDefinitions HOT 1
- Drupal Check incorrectly reporting "missing methods" on Interfaces, when methods actually exist on implementing class. HOT 6
- Class 'DrupalCheck\Application' not found in Docker project (PHP error) HOT 4
- Exclude Dir option is not working HOT 3
- Update Intracto sponsor to iO
- Add anonymous usage telemetry
- Bump PHPStan to level 2. HOT 1
- Inconsistency in drupal-check HOT 4
- Allow output to file or remove maintainers message HOT 2
- Add option to set phpVersion to 80100 for PHP 8.1 analysis on PHP 7.4
- Invalid JSON output HOT 1
- False violation on paragraph entity HOT 2
- Add jangregor/phpstan-prophecy and phpstan/phpstan-phpunit as dependencies HOT 1
- Allow custom config to be used HOT 1
- Dependency source logic not working
- Readme does not match actual options allowed in command.
- Conflict with phpcs for hook implementations HOT 1
- Global install no longer works in Drupal ^10.0.0 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from drupal-check.