dwarfs is difficult to build without the git repository (when not using the source tarball) about dwarfs HOT 11 CLOSED

Yes, it seems to work properly. Thank you.

from dwarfs.

I'd rather not go down that route as it will eventually result in the override not getting updated and thus binaries will be produced reporting a wrong version number.

It should be easy to build without the git repo if you use the source tarball. If you say you "prefer" to build from the git repo, it sounds like you could actually build from the tarball?

from dwarfs.

We already have infrastructure to automatically splice the version number into the git tag and the source code, so there is no risk of the override not getting updated in our scenario. You can see that here if you are curious: https://github.com/NixOS/nixpkgs/blob/b02fd49f1638f7241843aa5a4fe73d8bc9bf1599/pkgs/tools/filesystems/dwarfs/default.nix#L27 .

Yes, theoretically it's possible to use the source tarball. I have not tried, but I have checked it does have the relevant version files. But when the source tarball is not simply a tar of the related git hash and has ancillary files like this, it harms reproducibility which is why we prefer not to do it.

from dwarfs.

I'm worrying less about nix, more about others misusing the option.

I'll think about it.

from dwarfs.

Can you check if mhx/nixpkgs-version-override works for you? I've tested this locally with something like:

cmake .. -DWITH_TESTS=1 -DNIXPKGS_DWARFS_VERSION_OVERRIDE=v0.8.0 -GNinja

from dwarfs.

Don't test this yet, I should have waited for the CI pipeline to finish... ;)

from dwarfs.

Okay, this looks better.

from dwarfs.

Is there a reason to call this nixpkgs-specific? Is that a defense against misuse in your mind?

from dwarfs.

Is there a reason to call this nixpkgs-specific? Is that a defense against misuse in your mind?

It's both to document where the feature originated from and to discourage its use outside of nixpkgs. I still think it's a rather obscure use case. :)

from dwarfs.

Did you get a chance to test the code?

from dwarfs.

Thanks, merged into main.

from dwarfs.