Comments (1)
The issue is this. Imagine a pool of asynchronous tasks each submitting unrelated MPD commands. The pool grows as new tasks come in. I know MPD is a serial protocol so the main (library) mpd task linearizes the requests, but otherwise the tasks are independent. Now for whatever reason the client is disconnected, so let's follow the queue of MPD commands.
The first few commands interrupted mid-response will raise ProtocolError and be retried, bumped to the end of the queue.
The next commands will have no response and raise ConnectionError. They'll await a new connection and then retry the command, bumped to the end of the queue. The point is that for each disconnected command beyond the first I'll be making a redundant reconnection.
Then we get to the commands issued after the first successful re-connection. They'd have been successful if I hadn't reconnected again. Perhaps they'll work, or perhaps they'll raise a ProtocolError, but worst-case-scenario they raise ConnectionError and trigger another re-connection. It'll be an avalanche of connection errors.
The main mpd task needs to track the connection state to prevent unnecessary connections. I really hope I'm wrong and that there's a better way to do this, but right now I'm tracking the time I submit each MPD command and each time I reconnect to reconstitute the current connection state. But please - correct me if there's a better way.
from python-mpd2.
Related Issues (20)
- Code loosing connection HOT 16
- Add Mutex for MPD commands
- Delay of 0.1 seconds between asyncio MPD commands causes hang HOT 1
- Connection lost when using find() HOT 3
- asyncio client doesn't work with Python 3.10 HOT 3
- Queue `crop` command HOT 2
- Calling find with a search window (startend) fails HOT 1
- How to use noidle? HOT 3
- "group" keyword is not working correctly HOT 1
- Support for "contains" find/search expression filter HOT 1
- Asynchronous idle HOT 5
- asyncio races on responses HOT 1
- Error handling practice HOT 1
- v3.1.0 release missing from pypi HOT 2
- Test failures on Python 3.12 HOT 5
- How to avoid the large flow in the infinite loop HOT 2
- Support for seekthrough HOT 1
- regex search mode HOT 1
- Pending commands hang forever if connection breaks while reading MPD's response
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from python-mpd2.