Missing react-native-vector-icons dependency in package.json about react-native-form-generator HOT 6 CLOSED

Yes it's missing by now because it's required just for certain fields.
I'm planning to remove the dependency entirely.
Any thoughts?

On Thu, Mar 10, 2016, 6:24 PM Sam Fung [email protected] wrote:

LinkField has reference to react-native-vector-icons but it's not in
package.json. Therefore I got
Unable to resolve module react-native-vector-icons/Ionicons... error.

—
Reply to this email directly or view it on GitHub
#7.

from react-native-form-generator.

Can we use this.props.children within render() of LinkField to let user pass in the <Icon> as a child so that we can remove the dependency of react-native-vector-icon?

Replace https://github.com/MichaelCereda/react-native-form-generator/blob/master/fields/LinkField.js#L36-L38 with

  {this.props.children}

And this is how to add a right arrow to the link field:

<LinkField>
  <Icon name='ios-arrow-right'/>
</LinkField>

Just a quick thought, not sure it's right thing to do.

from react-native-form-generator.

Actually i was thinking a something more like this (to improve flexibility and allow developers to create their custom fields):

   <LinkField
      iconRight={<Icon name='ios-arrow-right'/>}
      label="Sample text"
   />

that should avoid problems... i'm preparing a new release right now and including also android support

from react-native-form-generator.

This is great. Looking forward to new release.

from react-native-form-generator.

i'm going to release the new version in minutes.
Android support will be included after a lot of tests (i'm developing a cross browser app).

from react-native-form-generator.

@5amfung, please check my release, added some other examples in the README file

from react-native-form-generator.