Tidal plugin 1.1.0 doesn't return all playlists about lms-plugin-tidal HOT 46 CLOSED

I found the issue. It's a paging problem. You have 60 playlist and paging is 50. When I set paging to 2, I only see 2 playlists...

from lms-plugin-tidal.

"your playlists": playlists you have created, or playlists you have added to your favorites?

from lms-plugin-tidal.

from lms-plugin-tidal.

Was there anything special about these playlists? I changed something there but I checked and all my playlists appear

from lms-plugin-tidal.

from lms-plugin-tidal.

Are they public or private?

from lms-plugin-tidal.

from lms-plugin-tidal.

from lms-plugin-tidal.

I tried again with my playlist: 2 privates and an existing public one that I added to my favorites and they all appear under "Playlists"... Is there anything more you can tell about how you created your playlists?

from lms-plugin-tidal.

Can you erase your LMS cache to be sure? (stop LMS and delete /var/lib/squeezeboxserver/cache/cache.db) and than that, a log with TIDAL set to info would be helpful.

from lms-plugin-tidal.

That's pretty much the issue I've tried to address in the past. I don't remember whether there was a well defined rule as to which playlists would show up and which one wouldn't... I fear it's time to re-introduce that not so elegant code...

from lms-plugin-tidal.

I would still like to go to the bottom of this as there has to be a logical reason and I know there is another api call as well.

from lms-plugin-tidal.

Just to elaborate, there is an API playlistsAndFavoritePlaylists but AFAIK, any playlist that I have created is always automatically in Favorites and I've not see an option for it not to be. To the OP, have you done something special for that? I'm wondering if this is not an obsolete feature.

Also, what bothers me if that if we need to use userPlaylist query, then we do not detect changes in there. Maybe the TTL is short enough so that we don't really care...

from lms-plugin-tidal.

from lms-plugin-tidal.

And if you create a fresh playlist, does it appear? Are you aware of any settings your would have change wrt blocking your playlists to be in favorites?

from lms-plugin-tidal.

from lms-plugin-tidal.

from lms-plugin-tidal.

from lms-plugin-tidal.

Ok, this is really insane - I've created a playlist 20 times using the tidal and it always appeared in favorites immediately. Anyway, I will use the other api but I'll have also to think about changes detection

from lms-plugin-tidal.

Can you share the code you used to create the playlist or at least the exact api calls?

from lms-plugin-tidal.

from lms-plugin-tidal.

What python frontend lib do you use? tamland/python-tifal?

from lms-plugin-tidal.

from lms-plugin-tidal.

It is conceivable that the "normal" UIs automatically add your playlist to your "favorites" and when you use the API it doesn't automatically add to favorites and/or it won't show up in your favorites API call. I was recently playing with the python tidalapi and found user.playlists(), but noted a few playlists missing and then found user.favorites.playlists() and it contained all of the playlists I wanted.

from lms-plugin-tidal.

Yes, likely this is the case. I'll change that to reorganize a bit the current version as there is a dedicated api call to get everything.

from lms-plugin-tidal.

I'm about to push and updated version, but what is interesting to see is that, at least on my setup, such playlists that are user-defined but removed from favorites through API disappear from the TIDAL app. They now remain on LMS and I assume on other apps using the API, but are gone on TIDAL. AFAIR, the TIDAL webapp uses a v2 version of the API for playlist, I traced that recently. So, it might be that, as in Deezer, when v2 is deployed, user playlist must be in favorites.

from lms-plugin-tidal.

I created a new public playlist in the Tidal app. It does NOT show up in LMS.

And that never been my experience. Every time I create a playlist in TIDAL, with v1.1 on this plugin, it always appeared in LMS. And I've done that many times.

from lms-plugin-tidal.

Thanks for looking into this, @philippe44!

from lms-plugin-tidal.

from lms-plugin-tidal.

Cool - it's just so weird why, using their official app, I can'reproduce the issue and have a user playlist that is NOT in favorite / collection.

from lms-plugin-tidal.

I'm sorry, i think i was a bit premature. Although my "old" Tidal playlists are now visible in LMS, newly created playlists, created by code but also created with the Tidal Desktop app, are NOT visible in LMS. The "new" playlists however are visible in both the Tidal desktop and mobile app. I'm not sure what's wrong.

from lms-plugin-tidal.

What country are you in? That does not make sense, I've tried times and times and times. So, you create a playlist "mine" in the desktop app, add tracks to it and it does NOT appear in LMS ???

from lms-plugin-tidal.

Netherlands

from lms-plugin-tidal.

Yep, i created a playlist, added titles to it in the Tidal desktop app. The playlist is visible in the Tidal app but not in LMS.

from lms-plugin-tidal.

@michaelherger : can you try on your side as well? This will drive me insane. I just tried again creating one in the desktop app (Windows) and the playlist was immediately visible in LMS. I did nothing special.

from lms-plugin-tidal.

@bkmill : how many playlists do you have?

from lms-plugin-tidal.

About 60. If needed for testing i can delete them because most of them are generated.

from lms-plugin-tidal.

https://github.com/michaelherger/lms-plugin-tidal/assets/9712599/99a33a43-b27e-449a-bd15-c3f7e14064b0
😠 😠 😠
I'm about to revert everything to 1.0 and take a hike

from lms-plugin-tidal.

My scenario is the same, the only difference is the playlist not showing up in LMS :-(

from lms-plugin-tidal.

Yep... you're right. I deleted most of my playlists and de newly created ones showed up. Pfieuuuwwww.

from lms-plugin-tidal.

Now I need to talk to @michaelherger / spend more time because I was reading the paging mechanism and now I'm totally confused.

from lms-plugin-tidal.

Take your time, i'm not in a hurry. Thank you for your effort.

from lms-plugin-tidal.

I think I've found something: I passed $acb as the callback for the _call method, which would return the result and the response object as the second argument. But $acb would consider a second argument an error. Thus would cut short and return only the first page of results, assuming the others failed.

By explicitly calling $acb->(shift) we only pass the result set. Which allows achain to evaluate all result sets of all the calls.

from lms-plugin-tidal.

Yes, my slow brain was getting there as well. Don't you think as well that _nocache => 1 should be set to every amap action?

from lms-plugin-tidal.

16d31a3

from lms-plugin-tidal.

I've checked and we must not cache the sub-page calls or at least we should follow what the initial request wrt cache was. I think it's not useful to cache these interim results knowing that we want to cache the final result, but more important, if we cache them (say we cache 0..49,50..99 and 100..120) then next time we have a request for the whole lot asking us to not cache or to refresh, then the first 0..49 will be refreshed/not use cache but the others will be taken from the previous cached data, which is wrong. Hence I think the best is to simply not cache sub-pages queries, rather than passing through _nocache/refresh.

from lms-plugin-tidal.