Status code should not always be 0 about crane HOT 9 CLOSED

I'll try to give it a go over the week-end

from crane.

Yes, definitely.
Looking forward to what you come up with!

from crane.

invalid container or group names passed via -g should also yield an error

from crane.

I had to map all docker errors to a generic one (service unavailable, because unless the UI changes, docker commands will most likely fail because the client can't communicate with the server) as it seems error codes are not portable across architectures covered by Go, and therefore there is no built-in API to get the exit code in ProcessState. This is the second time I try to write some go code though, so I might be completely wrong...

from crane.

Hmm. I don't know enough about Go either as to what the best way is. I just googled the issue and as far as I can tell, at least on Unix systems it seems to be the same (see http://golang.org/pkg/os/#ProcessState.Sys). I don't care about Windows (Docker does not even have a client for it anyway), so for me, that would be okay to use.

from crane.

You're right, I'll update it to propagate error codes on UNIX, without caring about anything else.

from crane.

Fixed in #30.

from crane.

Any chance you could bump out a release with this and the other recent changes? Thanks!

from crane.

Sure, https://github.com/michaelsauter/crane/releases/tag/v0.7.1.

from crane.