Giter VIP home page Giter VIP logo

Comments (4)

michaelsauter avatar michaelsauter commented on May 20, 2024

Thanks, glad you enjoy Crane.
--env-file might have changed, I think it was just a string when I implemented it.

Now, even if your Golang knowledge is quite basic, it's really easy to get into and a pull request would be highly welcome! Should be similar to https://github.com/michaelsauter/crane/blob/c13cb961be4aeeca74c0b182481370af723093bb/crane/container.go#L137-143.

Want to give it a shot?

from crane.

bjaglin avatar bjaglin commented on May 20, 2024

To be backward-compatible, and for sanity, I am wondering if it should also be possible to provide a string-value env-file as the syntax allows it today (and not be forced to use a single-element array) a la https://github.com/michaelsauter/crane/blob/c13cb96/crane/container.go#L232-L243. That would need to be done consistently for all flags that can be repeated though, so I guess it could be done in a separate PR.

from crane.

michaelsauter avatar michaelsauter commented on May 20, 2024

Crane is still not past 1.0, so I'm OK with breaking behaviour. I always wanted to be as close to raw Docker commands/flags as possible, so I think this is best implemented as array-only as that is what the official docs suggest.

from crane.

michaelsauter avatar michaelsauter commented on May 20, 2024

Closed via #98.

from crane.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.