Comments (4)
Thanks, glad you enjoy Crane.
--env-file
might have changed, I think it was just a string when I implemented it.
Now, even if your Golang knowledge is quite basic, it's really easy to get into and a pull request would be highly welcome! Should be similar to https://github.com/michaelsauter/crane/blob/c13cb961be4aeeca74c0b182481370af723093bb/crane/container.go#L137-143.
Want to give it a shot?
from crane.
To be backward-compatible, and for sanity, I am wondering if it should also be possible to provide a string-value env-file
as the syntax allows it today (and not be forced to use a single-element array) a la https://github.com/michaelsauter/crane/blob/c13cb96/crane/container.go#L232-L243. That would need to be done consistently for all flags that can be repeated though, so I guess it could be done in a separate PR.
from crane.
Crane is still not past 1.0, so I'm OK with breaking behaviour. I always wanted to be as close to raw Docker commands/flags as possible, so I think this is best implemented as array-only as that is what the official docs suggest.
from crane.
Closed via #98.
from crane.
Related Issues (20)
- Syncing many files with unison HOT 1
- Filter bind-mounts by configured accelerated mounts
- link option does not add container to /etc/hosts if it's not defined in the crane.yaml file HOT 3
- Initial sync never completes HOT 2
- crane run always creates a tilde directory HOT 6
- Add verbose log about ad-hoc containers
- Runtime error if a network is specified on a container, but the network isn't in the networks list HOT 1
- Add verbose flag to actual Crane command
- Fix SSH socket sharing
- Crane doesn't start multiple containers HOT 2
- env vars, build args errors / plugins and multi-config management HOT 2
- `ignore` config not respected for `accelerated-mounts` HOT 2
- need a little help fixing my crane.yml for new syntax HOT 2
- runtime nvidia/gpu support HOT 2
- Convert crane.yml to docker-compose.yml HOT 1
- Nil pointer error when running `crane lift -c deploy/docker-compose.yml` HOT 3
- Release ARM Binaries HOT 1
- Getting started: How to run container w/o config file HOT 1
- Convert crane.yaml to docker-compose.yaml HOT 5
- crane run - specifying extra args for CMD, leads to unexpected error
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from crane.