Giter VIP home page Giter VIP logo

Comments (4)

michalochman avatar michalochman commented on August 22, 2024

Hi @fbove, customApplyProps is not called unless the props change.

Could you explain what is your use case exactly so I can think understand it? In most scenarios it makes no sense to re-apply props (potentially costly operation) if they didn't change.

from react-pixi-fiber.

fbove avatar fbove commented on August 22, 2024

The example is:

import React from 'react'
import PropTypes from 'prop-types'

import Graphics from './Graphics'

class Arrows extends React.Component {
  findNode = nodeId => this.props.nodes.find(node => node.id === nodeId)
  computedArrows = () =>
    this.props.arrows.map(arrow => ({
      from: this.findNode(arrow.from),
      to: this.findNode(arrow.to)
    }))
  render() {
    // re-render here is ok (1)
    const arrows = this.computedArrows().map(arrow => (
      <Graphics
        key={`${arrow.from.id}-${arrow.to.id}`}
        from={arrow.from}
        to={arrow.to}
      />
    ))
    return arrows
  }
}

Arrows.propTypes = {
  nodes: PropTypes.arrayOf(
    PropTypes.shape({
      id: PropTypes.string.isRequired,
      x: PropTypes.number.isRequired,
      y: PropTypes.number.isRequired,
      w: PropTypes.number.isRequired,
      h: PropTypes.number.isRequired
    })
  ),
  arrows: PropTypes.arrayOf(
    PropTypes.shape({
      from: PropTypes.string.isRequired,
      to: PropTypes.string.isRequired
    })
  )
}

export default Arrows
import { CustomPIXIComponent } from 'react-pixi-fiber'
import * as PIXI from 'pixi.js'

const TYPE = 'Arrow'
export const behavior = {
  customDisplayObject: () => new PIXI.Graphics(),
  customApplyProps(instance, oldProps, newProps) {
    // Here I read "from" and "to" from newProps and create lines.
    // but this is not called
    this.applyDisplayObjectProps(oldProps, newProps)
  }
}

export default CustomPIXIComponent(behavior, TYPE)

Arrows is receiving updated props and re-rendering (1), but CustomPIXIComponent it's not. And it does have new props to show.

A workaround was to reset arrows on the state, inside the Component where I'm using Arrows.

this.setState({ arrows: [] })
this.setState({
  arrows: [...arrowsResp.arrows]
})

It'd probably be some React behavior I'm not aware of.

from react-pixi-fiber.

michalochman avatar michalochman commented on August 22, 2024

Do I understand correctly that you mean that the props are not applied the first time the CustomPIXIComponent object is created? If yes, then this is intended behaviour. You have customDisplayObject method for instantiation, where you can also apply any props you like.

customDisplayObject: () => new PIXI.Graphics(), is the easiest implementation, you could do something like this instead:

customDisplayObject: (props) => {
  const g = new PIXI.Graphics()
  // apply props to g here
  // ...
  return g
},

customApplyProps is then only called on subsequent renders. applyDisplayObjectProps is only a hook for your custom component that calls default, react-pixi-fiber function for applying props to components, as customApplyProps is bypassing default behaviour.

from react-pixi-fiber.

michalochman avatar michalochman commented on August 22, 2024

Closing as I think the above is the correct way to solve this. Let me know if not.

from react-pixi-fiber.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.