Better NULL input checking? about pgsodium HOT 3 CLOSED

Yep, I've pushed some changes to the same that allow for NULL associated with det and ietf and keeping support for NULL nonce with det. It's working well, so I'm going to apply the same pattern across the library.

from pgsodium.

Hi,

Throwing error from functions seems better:

• returning NULL without explanation might be tricky for new users to understand
• it allows a mix of NULL-able args and NOT NULL ones.

from pgsodium.

I'm not qualified enough with encryption to review your patch, but it seems nonce and additional data are optional with aead_det_*, am I right? See: https://github.com/jedisct1/libsodium-xchacha20-siv#usage

With ietf variant, it seems only additional data can be left NULL, right? https://doc.libsodium.org/secret-key_cryptography/aead/chacha20-poly1305/ietf_chacha20-poly1305_construction#combined-mode

Does it worth sticking with this from the pgsodium point of view?

from pgsodium.