Corrupted flash memory writes for Atmega328p with ISP interface about pymcuprog HOT 4 OPEN

Logged internally as DSG-7318.
Thanks for reporting this and providing a fix!
We currently don't do pull-requests directly on github but the patch can be made on our git repo and the fix will be in place in the next release. We have just recently completed a release, so can't yet comment on when this might be done.

from pymcuprog.

@xedbg Thank you for taking the time to look at this
You may have a look at this #PR for proposed fix.
Have a great day !

from pymcuprog.

I think your fix works... interesting though, the tool protocol also has a delay argument which is not correctly used. This fix in pyedbglib's avrispprotocol.py could arguably be more "correct" when seen from the tool firmware:

Add parameter to write_flash_page:

# def write_flash_page(self, byte_address, data):
def write_flash_page(self, byte_address, data, delay_ms=5):

Then send in the delay to the tool firmware and set bit 6 to make use of it:

# command.extend([0x81])  # Page mode
# command.extend([0])  # Not used
command.extend([0x91])  # Write page with timed delay
command.extend([delay_ms])

from pymcuprog.

@xedbg Thanks for the review and the proposed fix.
I can't help but agree with you on your suggested fix... Tested and worked just perfectly 💯
I opened a #PR to bring your suggested fix to life in the next release hopefully 😃

from pymcuprog.