Giter VIP home page Giter VIP logo

Comments (6)

ilopmar avatar ilopmar commented on June 4, 2024 1

The acmeVersion upgrade shouldn't target Micronaut 2.5.x patch release.

I'm just curious, is there a (technical) reason for this other than the Micronaut team wants to focus efforts on the Micronaut 3 release?

Basically we don't upgrade 3rd party minor dependencies in Micronaut patch versions because we don't want to break users' applications. See https://github.com/micronaut-projects/micronaut-core/wiki/Module-Upgrade-Strategy. Of course there can be exceptions to that rule (an maybe this is one of those)

Another approach if you really need acme upgraded is that we can release a new version targeting 2.5.x but that version won't be included in the bom automatically, so you need to set the version manually.

Probably all these changes you are doing should be done directly for Micronaut 3 release (#148)

Sure. Sounds like that will be more in alignment with what the core team is doing. (I guess that means I better test my apps out with Micronaut 3.0-M2...)

Will this work be done on master?

Yes, we will do all that work in master and we'll create a new branch for the previous version. But as I said, we can do another release for 2.5.x if you need it, so that will be first in master and we'll switch branches.

from micronaut-acme.

msgilligan avatar msgilligan commented on June 4, 2024

To get JDK 16 build to work:

  1. PR #152
  2. Update a handful of dependencies (see list below and other PRs)
  3. Comment out plugin: "io.micronaut.build.internal.dependency-updates"

I upgraded:

micronautVersion=2.5.6
groovyVersion=3.0.8
spockVersion=2.0-groovy-3.0
acmeVersion=2.11
objenesisVersion=3.2

from micronaut-acme.

ilopmar avatar ilopmar commented on June 4, 2024

The acmeVersion upgrade shouldn't target Micronaut 2.5.x patch release. Probably all these changes you are doing should be done directly for Micronaut 3 release (#148)

from micronaut-acme.

msgilligan avatar msgilligan commented on June 4, 2024

The acmeVersion upgrade shouldn't target Micronaut 2.5.x patch release.

I'm just curious, is there a (technical) reason for this other than the Micronaut team wants to focus efforts on the Micronaut 3 release?

Probably all these changes you are doing should be done directly for Micronaut 3 release (#148)

Sure. Sounds like that will be more in alignment with what the core team is doing. (I guess that means I better test my apps out with Micronaut 3.0-M2...)

Will this work be done on master?

from micronaut-acme.

msgilligan avatar msgilligan commented on June 4, 2024

I am trying to release an app using Micronaut 2.5.x and I have been using a dockerBuildNative container successfully until I tried to add micronaut-acme. (See Issue #154 which reproduces the issue with a freshly-generated Micronaut Launch project)

So maybe another release for 2.5.x might be a good idea.

from micronaut-acme.

msgilligan avatar msgilligan commented on June 4, 2024

Fixed in 0f479c6
Thanks @ilopmar !

from micronaut-acme.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.