itertools.cycle fails for generators about micropython-lib HOT 4 CLOSED

Proposed fix: just copy the equivalent python implementation?

Do you mean copy from CPython stdlib? Simple copy is never simple copy, there're also licensing issues to account for.

Also, the above implementation clearly bloats memory in case simple sequence is passed, so I'd suggest to add check for that and avoid copying in that case (I know there're bunch of corner cases, but let's resolve them on being hit). Feel free to submit a patch.

from micropython-lib.

Do you mean copy from CPython stdlib?

No I just meant copying python implementation as shown from https://docs.python.org/3/library/itertools.html#itertools.cycle, not the actual C implementation.

from micropython-lib.

That definition almost mandates the given implementation. And, as it says, it's expected to use lots of memory.

from micropython-lib.

Fixed with #42

from micropython-lib.