Giter VIP home page Giter VIP logo

Comments (7)

kendallroden avatar kendallroden commented on July 28, 2024 1

You can use the CD scaffolding that we provide or use your own action with container apps as a target and you will not miss out on any functionality or need to in some way "connect" your github action outside of the typical workflow.

from azure-container-apps.

johnkors avatar johnkors commented on July 28, 2024

I tried to disconnect and re-connect GitHub actions in the "Continous Deployment" tab. Unfortunately, this leads to some unwanted side-effects:

  • It git pushes another auto-generated yml file (I already have one from the first setup process, so I have to delete it immediately)
  • It immediatly kicks of a deployment process (hey, I don't want to deploy right now, just enable CD mode)

Still cannot get back to "Continous Deployment" mode.

from azure-container-apps.

ahmelsayed avatar ahmelsayed commented on July 28, 2024

Hi @johnkors you can restore the original behavior by running

az containerapp update ... --traffic-weight latest=100

from azure-container-apps.

johnkors avatar johnkors commented on July 28, 2024

Ok, thanks!

Shouldn't that be included in the GitHub action?

What about the other side effects when disconnecting/connecting? Seems like unwanted behaviour. I had to do some minor tweaks to the GitHub Action yaml to get it to work, so any auto-generated are just noise anyhow. Would be better if we could just get the yaml, and choose to commit it ourselves rather than Azure forcing a deploy when connecting to GitHub.

from azure-container-apps.

johnkors avatar johnkors commented on July 28, 2024

If I just setup the GitHub action manually (I prefer this over what is generated) rather than thru az CLI or the azure portal, would CD still work?

Or are there other mechanisms in play dependent on it (ex. does it wire up some config between the container app and the registry, or smth)?

from azure-container-apps.

xwang971 avatar xwang971 commented on July 28, 2024

Hi, @johnkors Yes we would provide options for customers to decide if they want to push the file to workflow directory or not.

from azure-container-apps.

johnkors avatar johnkors commented on July 28, 2024

Could you answer the 2nd part as well?

Are there other mechanisms in play dependent on it (ex. does it wire up some config between the container app and the registry, or smth)?

from azure-container-apps.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.