Comments (5)
.NET 4.5 can be dropped and replaced with .NET 4.6.2.
Support for reflection-based serialization can't be completely dropped. There are uses where the object to be serialized isn't known at compile time.
So, I recommend splitting the trimming support from Roslyn-based source generation and tackling them on their own.
Let's let this issue focus on trimming.
from bond.
Inside of Microsoft, we currently don't need support for app trimming for those apps that use Bond. As such, we have no plans to implement this ourselves. Would you be interested in contributing this?
from bond.
Sure, why not! I’ve already looked at the code and I was wandering, why the projects are still targeting net4.5
and netstandard1.6
(they should be out of support by now).
It might actually be more desirable to move to roslyn source generator to allow for scenarios without the reflection and dynamic generation that seems to be going on behind the scenes.
This should not only improve (startup) performance but also fix this issue because there would be no dynamic elements that could be trimmed away.
from bond.
Would it be okay to simply target netstandard2.0
instead of net45;net46;netstandard1.3;netstandard1.6
?
It should be compatible with all other targets (except net45
).
See https://learn.microsoft.com/en-us/dotnet/standard/net-standard?tabs=net-standard-2-0
from bond.
Yes, solely targeting netstandard2.0
looks like it will work now that the floor for .NET Framework can be raised to 4.6.2. Thanks for checking the compatibility table. This will also allow clean up of all(?) the conditional compilation too. (Both the .cs and .csproj files will need to be updated.)
from bond.
Related Issues (20)
- Bond generated headers don't work for clang in c++20 HOT 2
- Include enums in Bond runtime schema HOT 1
- cmake/Config.cmake looks for the EOLed Python-2.7 HOT 1
- Deserialization/serialization under Linux is 7x-10x slower than Windows HOT 2
- [C#] gbc.exe: Exec format error inside mcr.microsoft.com/dotnet/sdk:latest docker image. HOT 3
- "openFile: does not exist (No such file or directory)" on Linux HOT 3
- [C#] Deserializing bond-like strings into dynamic type HOT 2
- Linux build error - ghc: panic! HOT 4
- Target `netstandard2.0` for c# HOT 1
- C++: GCC: Double/Float comparison warning HOT 2
- Is this project still being maintained? HOT 2
- emit #nullable enable pragma in generated C# code
- bond on aarch64 is failing with unsupported LLVM
- [msvc][cpplatest] bond failed to build with msvc option /std:c++latest due to error C2027 and error C2061
- Upgrade to Stack lts-22.12 for aarch64 support
- Simple usage example for python HOT 1
- Is it possible to use Python bindings without Boost? HOT 1
- Compilation failed with msvc version 14.39.33519
- Following HLint suggestions?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bond.