Multiple @key on a model crashes the compiler about cadl HOT 10 CLOSED

I do think in practice it's common to have multiple foreign keys on an object, even when the entities they belong to themselves have a parent-child relationship. E.g. if kennel belongs to store and pet belongs to kennel, you will often find pets with both kennel_id and store_id, even though you can find the store_id through one indirection.

from cadl.

Why does this trigger unhandled promise rejection?

from cadl.

That probably escapes the new catch-all in the language server.

from cadl.

That was in the cli not language server, didn't check if it crashed that

from cadl.

Seems like there's a missing await somewhere too here?

from cadl.

Side note: do we want to support multiple keys per model type? We could get rid of the error entirely.

from cadl.

Someone was saying during the bug bash review that we were supposed to support that.

from cadl.

It was me! I thought I saw it was required when my model has two keys, like a pet with a store ID and group ID or something. But I see now we just use the parent model relationship so I was mistaken.

from cadl.

Honestly I don't see any reason why we couldn't use either approach. The code I've written is only really concerned with the order of the keys, it could generate a path just fine for a model type with two or more key properties, even if it has multiple parents.

from cadl.

• this issue is about fixing the exception to make it a diagnostic
• Adding a design issue for whether multiple keys can be valid for a resource

from cadl.