Recent VsDbg versions missing System.Threading.Tasks.dll assembly about concordextensibilitysamples HOT 4 CLOSED

I opened #90 to serve as the announcement page for new releases.

from concordextensibilitysamples.

Hi Simon, sorry for the delay.

We can definitely add System.Threading.Tasks to the vsdbg folder for our next release. If you want to share the full list of your dependencies, I think it might make sense to include all of them as roots to our trimmer to make sure we don't remove any others in the future.

As for notification when a new vsdbg release is out, do you have a preferred mechanism? One though I had would be to have a GitHub issue that we could update as part of releases.

from concordextensibilitysamples.

Hi Gregg, I think System.Threading.Tasks.dll is the only missing dependency (certainly I could copy it in and everything worked ok again). Most of our dependencies are a consequence of using StreamJsonRpc and async interfaces. When we first did this work I got you to add a few other shared assemblies (System.Buffers.dll, System.Threading.Tasks.DataFlow.dll, System.Threading.Timer.dll and System.IO.Pipes.dll) so as long as they don't go missing I think we're good.

For release info, a github issue sounds good to me. I've gleaned most of my information from various release note entries and PRs over in the omnisharp vscode repo but there's a lot of other noise there obviously.

from concordextensibilitysamples.

All of those are currently on our list of assemblies that we will never trim away. Here is our current list:

    <TrimRoots Include="System.Buffers.dll" />
    <TrimRoots Include="System.Diagnostics.Process.dll" />
    <TrimRoots Include="System.IO.Pipes.dll" />
    <TrimRoots Include="System.Reflection.Emit.dll" />
    <TrimRoots Include="System.Threading.Tasks.Dataflow.dll" />
    <TrimRoots Include="System.Threading.Timer.dll" />
    <TrimRoots Include="System.Threading.Tasks.dll" /> // Just added, hasn't shipped yet
    <TrimRoots Include="System.ValueTuple.dll" /> // Just added, hasn't shipped yet

from concordextensibilitysamples.